From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#30955: 27.0.50; Mouse clicks on header-line in Info are broken Date: Tue, 27 Mar 2018 14:46:01 -0400 Message-ID: References: <83po3qga5g.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1522176310 12672 195.159.176.226 (27 Mar 2018 18:45:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Mar 2018 18:45:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Colin Baxter To: 30955@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 27 20:45:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0taj-0003Cr-Tr for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Mar 2018 20:45:06 +0200 Original-Received: from localhost ([::1]:35649 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0tcn-0000GE-4b for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Mar 2018 14:47:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0tch-0000Fy-5j for bug-gnu-emacs@gnu.org; Tue, 27 Mar 2018 14:47:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0tcc-0004J6-9z for bug-gnu-emacs@gnu.org; Tue, 27 Mar 2018 14:47:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48334) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0tcc-0004Iz-6W for bug-gnu-emacs@gnu.org; Tue, 27 Mar 2018 14:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f0tcb-0007WF-Nx for bug-gnu-emacs@gnu.org; Tue, 27 Mar 2018 14:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Mar 2018 18:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30955 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30955-submit@debbugs.gnu.org id=B30955.152217636628832 (code B ref 30955); Tue, 27 Mar 2018 18:47:01 +0000 Original-Received: (at 30955) by debbugs.gnu.org; 27 Mar 2018 18:46:06 +0000 Original-Received: from localhost ([127.0.0.1]:56231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0tbi-0007Ux-0f for submit@debbugs.gnu.org; Tue, 27 Mar 2018 14:46:06 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:50502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0tbf-0007Ud-5N for 30955@debbugs.gnu.org; Tue, 27 Mar 2018 14:46:05 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2RIk1gY029905; Tue, 27 Mar 2018 14:46:01 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 14CDF663C5; Tue, 27 Mar 2018 14:46:01 -0400 (EDT) In-Reply-To: <83po3qga5g.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 26 Mar 2018 17:54:19 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6251=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6251> : inlines <6522> : streams <1782435> : uri <2615857> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144655 Archived-At: > To reproduce: > > emacs -Q > C-u C-h i /path/to/info/elisp.info RET > 2 > 3 > 4 > Click mouse-1 on the "Up: Programming Types" link on the header-line Hmm... I reduced it to src/emacs -Q --eval '(info "(elisp)Numbers")' Click mouse-1 on the "Up" link on the header-line and I fixed the "obvious" problem (see patch below), but now that just gives me: is undefined instead of is undefined So now the event-rewrite gives the expected result (i.e. " "), but for some reason it decides it's unbound even tho it clearly is. IOW it seems to be looking in the wrong keymap(s). Stefan "not looking forward to debug sessions in read_key_sequence" diff --git a/lisp/mouse.el b/lisp/mouse.el index 6a98ee7353..fe8b76e953 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -135,7 +137,12 @@ mouse--click-1-maybe-follows-link (unless (get newup 'event-kind) (put newup 'event-kind (get (car last-input-event) 'event-kind))) - (vector (cons newup (cdr last-input-event))))))))) + ;; Modify the event in-place, otherwise we can get a prefix + ;; added again, so a click on the header-line turns + ;; into a [header-line header-line mouse-2] :-(. + ;; See fake_prefixed_keys in src/keyboard.c's. + (setf (car last-input-event) newup) + (vector last-input-event))))))) (define-key key-translation-map [down-mouse-1] #'mouse--down-1-maybe-follows-link)