all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 51f0ccc: Put follow-mode's engine on pre-redisplay-hook instead of post-command-hook
Date: Wed, 03 Oct 2018 08:20:30 -0400	[thread overview]
Message-ID: <jwvbm8bw7qn.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20181003105359.AA7EC204E8@vcs0.savannah.gnu.org> (Alan Mackenzie's message of "Wed,  3 Oct 2018 06:53:59 -0400 (EDT)")

Hi Alan,

>     Put follow-mode's engine on pre-redisplay-hook instead of
>     post-command-hook

Yay!

> +(defun follow-pre-redisplay-function (wins)
> +  (if (or (eq wins t)
> +          (null wins)
> +          (and (listp wins)
> +               (memq (selected-window) wins)))
> +      (follow-post-command-hook)))

I'm not sure it's possible for (selected-window) not to be memq of wins,
but even if it is, it's likely to be extremely rare.  So the above (or ...)
is probably just a complicated way to say `t`.

> +;; The magic little box. This function was formerly called after every
> +;; command.  It is now called before each redisplay operation (see
> +;; `follow-pre-redisplay-function' above), and at the end of several
> +;; search/replace commands.  It retains its historical name.

I wonder why this is still needed.


        Stefan



       reply	other threads:[~2018-10-03 12:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181003105358.19923.64797@vcs0.savannah.gnu.org>
     [not found] ` <20181003105359.AA7EC204E8@vcs0.savannah.gnu.org>
2018-10-03 12:20   ` Stefan Monnier [this message]
2018-10-03 13:14     ` [Emacs-diffs] master 51f0ccc: Put follow-mode's engine on pre-redisplay-hook instead of post-command-hook Alan Mackenzie
2018-10-03 13:52       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvbm8bw7qn.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.