From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Thoughts on getting correct line numbers in the byte compiler's warning messages Date: Thu, 01 Nov 2018 18:45:00 -0400 Message-ID: References: <20181101175953.GC4504@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1541112890 4466 195.159.176.226 (1 Nov 2018 22:54:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Nov 2018 22:54:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 01 23:54:46 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gILrS-00015k-7P for ged-emacs-devel@m.gmane.org; Thu, 01 Nov 2018 23:54:46 +0100 Original-Received: from localhost ([::1]:47003 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gILtY-00033F-OK for ged-emacs-devel@m.gmane.org; Thu, 01 Nov 2018 18:56:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gILrl-0002XY-QJ for emacs-devel@gnu.org; Thu, 01 Nov 2018 18:55:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gILi9-0005qE-IV for emacs-devel@gnu.org; Thu, 01 Nov 2018 18:45:12 -0400 Original-Received: from [195.159.176.226] (port=48090 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gILi9-0005p5-8u for emacs-devel@gnu.org; Thu, 01 Nov 2018 18:45:09 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1gILg0-00051E-6I for emacs-devel@gnu.org; Thu, 01 Nov 2018 23:42:56 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 12 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:vtTsoKcpxqh8z3ovchTsSHjVB9w= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230967 Archived-At: > The third idea is to amend the reader so that whereas it now produces a > form, in a byte compiler special mode, it would produce the cons (form . > offset). So, for example, the text "(not a)" currently gets read into Sounds good. I have the vague feeling that I mentioned it already, but in case I haven't: please make sure the positions are character-precise rather than line-precise, so that we can (eventually) ditch Edebug's Elisp-reimplementation-of-the-reader which returns the same kind of info (and needs character-precise location info). Stefan