From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master aa5513d 1/7: excorporate-diary: Always use diary-fancy-display Date: Sun, 16 Jun 2019 18:56:02 -0400 Message-ID: References: <20190614211218.5886.59920@vcs0.savannah.gnu.org> <20190614211219.59B5721012@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="261587"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 17 00:57:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hce5K-0015uU-Fu for ged-emacs-devel@m.gmane.org; Mon, 17 Jun 2019 00:57:14 +0200 Original-Received: from localhost ([::1]:43286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hce5I-0000en-Pm for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 18:57:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55224) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hce4U-0000Dz-Kq for emacs-devel@gnu.org; Sun, 16 Jun 2019 18:56:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hce4S-0003tU-LS for emacs-devel@gnu.org; Sun, 16 Jun 2019 18:56:22 -0400 Original-Received: from [195.159.176.226] (port=53282 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hce4O-0003pK-S8 for emacs-devel@gnu.org; Sun, 16 Jun 2019 18:56:18 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hce4H-0014pM-8n for emacs-devel@gnu.org; Mon, 17 Jun 2019 00:56:09 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:CyGZ7NEjCO6cEK/pK+4kMBIbAM8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237757 Archived-At: > Thanks for reviewing. Yeah, I didn't like having to do that but the > stock alternative, diary-simple-display, is broken. FWIW, the default is already the fancy display: % grep diary-display-function **/*.el [...] lisp/calendar/diary-lib.el:(defcustom diary-display-function #'diary-fancy-display So if the user gets broken behavior it's presumably because of a specific choice in its config, I think it's OK to just explain the reason to the user without trying to impose a particular fix. Stefan