From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 21867@debbugs.gnu.org, zkanfer@gmail.com
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Date: Fri, 02 Aug 2019 16:16:37 -0400 [thread overview]
Message-ID: <jwvblx7tjo7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8736ijak7u.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Fri, 02 Aug 2019 13:19:01 +0200")
> retry:
> do
> - val = read_char (0, Qnil, (input_method ? Qnil : Qt), 0,
> - NUMBERP (seconds) ? &end_time : NULL);
> + {
> + val = read_char (0, Qnil, (input_method ? Qnil : Qt), 0,
> + NUMBERP (seconds) ? &end_time : NULL);
> + record_char (Qnon_command_character);
> + }
Currently, the view-lossage doesn't actually say
`a C-h l` resulted in running view-lossage
contrarily to what Lars seems to assume (and I guess, contrarily to
what the display suggests). Instead it just says
we saw `a` then `C-h` then `l` then view-lossage was run
I think considering this problem as specific to `read-char` is kinda wrong
(after all, `read-char` can be called as part of input-decode-map in
which case the event still very much belongs to "the events that resulted
in running a particular command"; this happens for example for
mouse-clicks in xterm-mouse-mode).
So I think maybe a better way to look at it is to add marker
pseudo-events like `end-of-command` (e.g. after running
post-command-hook), so we can discover that `a` was processed as part of
the execution of the command bound to `C-x C-e` rather than as part of
the sequence of events that triggered view-lossage.
Stefan
next prev parent reply other threads:[~2019-08-02 20:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 4:58 bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands Zachary Kanfer
2019-08-01 18:05 ` Lars Ingebrigtsen
2019-08-01 18:21 ` Eli Zaretskii
2019-08-01 18:41 ` Lars Ingebrigtsen
2019-08-01 18:51 ` Eli Zaretskii
2019-08-01 18:58 ` Lars Ingebrigtsen
2019-08-01 19:18 ` Eli Zaretskii
2019-08-01 19:25 ` Lars Ingebrigtsen
2019-08-02 6:41 ` Eli Zaretskii
2019-08-02 11:19 ` Lars Ingebrigtsen
2019-08-02 12:02 ` Eli Zaretskii
2019-08-02 20:16 ` Stefan Monnier [this message]
2019-08-03 12:13 ` Lars Ingebrigtsen
2019-08-03 21:07 ` Stefan Monnier
2019-08-03 21:14 ` Lars Ingebrigtsen
2019-08-03 21:49 ` Juri Linkov
2019-08-04 11:45 ` Lars Ingebrigtsen
2019-08-04 21:04 ` Juri Linkov
2019-08-04 12:54 ` Stefan Monnier
2019-08-04 19:44 ` Juri Linkov
2019-08-05 18:36 ` Stefan Monnier
2019-08-07 18:31 ` Lars Ingebrigtsen
2019-08-23 1:41 ` Lars Ingebrigtsen
2019-08-05 9:15 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvblx7tjo7.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=21867@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=zkanfer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.