From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f225011: ibuffer-do-isearch: don't depend on `cl-values-list' (bug#38430) Date: Sun, 01 Dec 2019 20:55:02 -0500 Message-ID: References: <20191201091356.26612.95511@vcs0.savannah.gnu.org> <20191201091358.11752207E0@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173565"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 02 02:55:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ibavm-000j0a-HL for ged-emacs-devel@m.gmane.org; Mon, 02 Dec 2019 02:55:19 +0100 Original-Received: from localhost ([::1]:57788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibavk-0003t9-Kz for ged-emacs-devel@m.gmane.org; Sun, 01 Dec 2019 20:55:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54249) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibave-0003t0-L2 for emacs-devel@gnu.org; Sun, 01 Dec 2019 20:55:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibavc-0007xF-L9 for emacs-devel@gnu.org; Sun, 01 Dec 2019 20:55:09 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2677) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ibavc-0007vv-EQ for emacs-devel@gnu.org; Sun, 01 Dec 2019 20:55:08 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9C11181257; Sun, 1 Dec 2019 20:55:06 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BD3DA80048; Sun, 1 Dec 2019 20:55:04 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1575251704; bh=qwct32ODkzHQpXagxYh11jDIIquPqxMDWtIhpdMRMvg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Qr9IrzRXQTz/LFx1GhiaoYzZP1B0GwXDUQCOd6flunf0Ca6MBPFLc+5NOjKXjueTp CZsK32wN94N8vY00pRiZ/OwpWkxQcnCXMGlMD9+ty3BFEndjU/CYL+ZJZqgVPlEvaX RQIKxTBGr8e6/p/mPG8ojwzlpnQZRG9/bvNFmYIbb/0b7bTcEc3JzxzqNg/UdpeOB3 UULmsDZ5BUxFRIOwl94DohIAI+J1H3BTv62w8f8TouFEUyzWRp8PUXUfOcfAwr7buR KzodQlAx8H12FfVyw8qOdFvHuiX7DUTLW2oEeWWeAxmn09rUBLMeRqnLyxQAVR7lWB 46jrjcYJiRViQ== Original-Received: from pastel (unknown [45.72.134.213]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 830A912048D; Sun, 1 Dec 2019 20:55:04 -0500 (EST) In-Reply-To: (Juanma Barranquero's message of "Mon, 2 Dec 2019 00:36:32 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242981 Archived-At: >> This is "broken" in the sense that it makes assumptions about how the >> "multiple values" are implemented. > Yes, though we've had that implementation for decades and we're not likely > going to add true multiple values to elisp. I must admit I'm biased: I find c-lib's multiple-value support to be completely worthless. I don't know anything you can do with that you can't do just as easily without it. IOW it only makes sense as a "compatibility with Common-Lisp", yet it doesn't provide the right semantics either so it doesn't work for that either. I regret not having noticed it back in Emacs-24 time when I could have marked those functions as obsolete (or even kept them in cl.el but not in cl-lib.el). >> We do know that `ibuffer-split-list` returns a list, so there's no point >> going through CL's multiple-values simulation. We should instead treat >> it as a list and extract the elements with `pcase-let` >> (or `cl-destructuring-bind`). > I tried to do a minimal fix so close to branching for 27, but I can do that > if you want. I consider the patch you showed as broken (regardless of whether it does work in practice, obviously). Require cl-lib is another way to fix this, if you want a less intrusive patch. But we're still "before branching", so I wouldn't worry about intrusiveness yet. Stefan