From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master f225011: ibuffer-do-isearch: don't depend on `cl-values-list' (bug#38430)
Date: Sun, 01 Dec 2019 20:55:02 -0500 [thread overview]
Message-ID: <jwvblsrcx8q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAAeL0SSP9WYAGSDVv1uH+aXuE4iGenrZZAWOxtT467OTs+M2VA@mail.gmail.com> (Juanma Barranquero's message of "Mon, 2 Dec 2019 00:36:32 +0100")
>> This is "broken" in the sense that it makes assumptions about how the
>> "multiple values" are implemented.
> Yes, though we've had that implementation for decades and we're not likely
> going to add true multiple values to elisp.
I must admit I'm biased: I find c-lib's multiple-value support to be
completely worthless. I don't know anything you can do with that you
can't do just as easily without it. IOW it only makes sense as
a "compatibility with Common-Lisp", yet it doesn't provide the right
semantics either so it doesn't work for that either.
I regret not having noticed it back in Emacs-24 time when I could have
marked those functions as obsolete (or even kept them in cl.el but not
in cl-lib.el).
>> We do know that `ibuffer-split-list` returns a list, so there's no point
>> going through CL's multiple-values simulation. We should instead treat
>> it as a list and extract the elements with `pcase-let`
>> (or `cl-destructuring-bind`).
> I tried to do a minimal fix so close to branching for 27, but I can do that
> if you want.
I consider the patch you showed as broken (regardless of whether it
does work in practice, obviously). Require cl-lib is another way to fix
this, if you want a less intrusive patch. But we're still "before
branching", so I wouldn't worry about intrusiveness yet.
Stefan
next prev parent reply other threads:[~2019-12-02 1:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191201091356.26612.95511@vcs0.savannah.gnu.org>
[not found] ` <20191201091358.11752207E0@vcs0.savannah.gnu.org>
2019-12-01 18:29 ` master f225011: ibuffer-do-isearch: don't depend on `cl-values-list' (bug#38430) Stefan Monnier
2019-12-01 23:36 ` Juanma Barranquero
2019-12-02 0:39 ` Juanma Barranquero
2019-12-02 1:55 ` Stefan Monnier [this message]
2019-12-02 2:20 ` Juanma Barranquero
2019-12-02 3:40 ` Eli Zaretskii
2019-12-02 3:43 ` Juanma Barranquero
2019-12-02 15:38 ` Eli Zaretskii
2019-12-02 17:18 ` Juanma Barranquero
2019-12-02 17:40 ` Eli Zaretskii
2019-12-02 18:10 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvblsrcx8q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.