From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Native compilation: the bird-eye view Date: Mon, 24 Aug 2020 09:31:53 -0400 Message-ID: References: <83o8qocd32.fsf@gnu.org> <838shrdb1c.fsf@gnu.org> <837dxbd93b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32404"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , Paul Eggert , "Andrea Corallo via Emacs development discussions." To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 24 15:32:42 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kACaY-0008Ij-Ji for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Aug 2020 15:32:42 +0200 Original-Received: from localhost ([::1]:48842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kACaX-0001E0-Jm for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Aug 2020 09:32:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kACZt-0000mD-Cl for emacs-devel@gnu.org; Mon, 24 Aug 2020 09:32:01 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:58984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kACZr-0003JG-7L; Mon, 24 Aug 2020 09:32:00 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4B5D81002D8; Mon, 24 Aug 2020 09:31:57 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8F2C210022E; Mon, 24 Aug 2020 09:31:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598275915; bh=z3lT9Y5LNi3GHmfx8uZHklTTyUV327jaIalhqJhAkMw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oVak5ZZ/NB/CzDw4dsEO8QKZ4adNg+XoOBh50PXkB4DtM+zMNv7/dsuD39+86jQhS bnSCvLPM12IC9En84CZw35StS+2d583wvYZe2ettl9bIL3wamYRwZpy4+n7La9HYC+ Zo7WHFrFivIEvgdfbYiYXU7T/jRMyJ7dCW/AaGQCEUSyXCxviG3Zxc4T6tADYEtcPX QZndYN1AkWgMfCNOFBB1VmC8XXSnJBkIQASlC2GUYHvMZiYT9bjDndi3LFzC6JO8w3 OXkjEwBOp39jhzkRPgARJwK2kzRRbaVaSCZYo4PgmZx5X8Gm8MOkyiiOUOaFr0KryW CEEk1kBHspe6g== Original-Received: from alfajor (unknown [45.72.246.108]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 017291202FB; Mon, 24 Aug 2020 09:31:54 -0400 (EDT) In-Reply-To: (Andrea Corallo's message of "Mon, 24 Aug 2020 08:03:23 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/24 09:31:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254179 Archived-At: >> What I was thinking of doing was: when we generate a new .elc file, just >> before saving the file over the old .elc file, we compute the hash of the >> old .elc file and erase any matching .eln file. > > Remeber ATM the input to the ashing is the .el content and not the .elc, > this motivated by: Hmm... > - The .elc may not capture all the input to the compilation that have > an effect on the native code generation (I don't have a working > example for this is just a suspect). The problem is the opposite: it's the .el file which doesn't account for the complete information (e.g. you may have to recompile a .el file even if it hasn't changed, because some of the macros it uses have been modified). The .elc files are less affected by such problems. >> Note that for the "system-wide" .eln files it can be trickier because we >> may want to generate them once and then use them with Emacs installed at >> difference locations, so we'd then want to try and avoid using the >> absolute file name (and instead use file names that are relative to the >> root of the Emacs install or something). > > I think in this case we could generalize what we have in place now to > allow reusing the same eln for local build and installed. > > We are currently replacing in the filename if matches > PATH_DUMPLOADSEARCH or PATH_LOADSEARCH with '//' before feeding the hash > algorithm. Sounds good, Stefan