From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/completions-highlight-modifications e3c5b99 3/6: Add completions-highlight-mode initial implementation. Date: Fri, 20 Nov 2020 09:24:36 -0500 Message-ID: References: <20201115224943.o5r7lkkblmyt2ox4@Ergus> <20201116033719.63dryvqm4ozfer2r@Ergus> <92f3cbd7-29a0-461a-a023-562bc6020ea8@default> <87v9e5herj.fsf@mail.linkov.net> <20201116102729.ywubtda6cqdzc45z@Ergus> <87d00acuh3.fsf@mail.linkov.net> <20201119032519.lpa53ixezgpdppze@Ergus> <87d009kfmf.fsf@mail.linkov.net> <20201119105052.kfichqojkhfwwsiz@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16803"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Drew Adams , Juri Linkov To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 20 15:25:30 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kg7Lu-0004GI-5M for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Nov 2020 15:25:30 +0100 Original-Received: from localhost ([::1]:34760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kg7Lt-0007d2-4C for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Nov 2020 09:25:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kg7L7-00070M-Md for emacs-devel@gnu.org; Fri, 20 Nov 2020 09:24:41 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56958) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kg7L6-0005zX-7D for emacs-devel@gnu.org; Fri, 20 Nov 2020 09:24:41 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3829A1001D2; Fri, 20 Nov 2020 09:24:39 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 623EF10024D; Fri, 20 Nov 2020 09:24:37 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1605882277; bh=UP9zUQhnjEK/vGIltfnAFadMsLliZoZ7gPCHX2yGtoI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=e4LNEocur/A/eqeScVyOacn/v1t8vOZ4dKinBlWAXkh37uE7z3YBOVYTQslDoiAvs sz8vE11N5TckMQMs5eTF2odqcPPKNtbO59MMvVr5ldsmXpdP+YfCkJ5yacYT7D3dK4 /USaNX1oKUe5g/CMKWx1N60fwDEimSLTR2ZJxV3gLs4fnOFs9pwLjWi0AAZ3s3hSK5 3JUErXUNcrzLgbED9eKFTi4gQlhIAcKsEHchrIkvv+AIktb7xFyNL2x+a5ZRiaVVa6 +YOR4bjDdFZQxIX2H2+srSksNSLnz7EWiJWD3GA5wl/pfgQxpH+YFUykhhUNO55gkq w4Fp+/CECDLMQ== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 27EA61201B3; Fri, 20 Nov 2020 09:24:37 -0500 (EST) In-Reply-To: <20201119105052.kfichqojkhfwwsiz@Ergus> (Ergus's message of "Thu, 19 Nov 2020 11:50:52 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259486 Archived-At: >>Adding much more code to simple.el is undesirable indeed, but >>for the completion highlighting feature it would take only >>~20 lines of code and option/face definition in minibuffer.el. > Indeed. I already did that on the beginning, but then I moved it > out. Actually If I can choose it will be better if all the *Completions* > stuff are moved to their own file... Hmm... minibuffer.el *is* "their own file". Stefan