From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 80e2647: * lisp/filesets.el: Use lexical-binding
Date: Fri, 12 Mar 2021 11:59:00 -0500 [thread overview]
Message-ID: <jwvblbofgx0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87h7lguys8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 12 Mar 2021 17:23:03 +0100")
> Now, filesets.el is a twisty maze of functions, but this seems to be
> called via the `filesets-commands' alist, and `filesets-cmd-get-def'
> which is called from `filesets-cmd-get-fn', which is called from
> `filesets-run-cmd'. Which binds `files' lexically, but is probably what
> `filesets-cmd-isearch-getargs' is trying to access?
>
> I'm not really confident about that analysis, though...
Ah the wonderful world of dynamic scoping ;-)
I agree with your analysis and pushed a patch that presumes you
were right.
Stefan
prev parent reply other threads:[~2021-03-12 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210104232347.21177.41247@vcs0.savannah.gnu.org>
[not found] ` <20210104232349.75BA220CB7@vcs0.savannah.gnu.org>
2021-03-12 16:23 ` master 80e2647: * lisp/filesets.el: Use lexical-binding Lars Ingebrigtsen
2021-03-12 16:59 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvblbofgx0.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.