all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org>
To: help-gnu-emacs@gnu.org
Subject: Re: replace-regexp
Date: Sat, 08 May 2021 09:53:06 -0400	[thread overview]
Message-ID: <jwvbl9l5o9l.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: CAP_d_8VFdat+2OBrLTraaVskGZncbMCSGD9Ck3j31RQkxO_Bqw@mail.gmail.com

>> > Maybe it has something to do with the replacement being
>> > longer than the original string?
>>
>> That's it, I think, as this doesn't give me the error:
>>
>> (defun md-latex-reduce (beg end)
>>   (interactive "r")
>>   (save-excursion
>>     (goto-char beg)
>>     (while (re-search-forward "_\\(.*\\)_" end t)
>>       (replace-match "\\1") )))
>
> And this is probably one of the reasons why most[citation needed]
> tutorials, when implementing a function operating on a region, do a
> ‘narrow-to-region’ first thing.
>
>     (defun md-latex-reduce (beg end)
>       (interactive "r")
>       (save-excursion
>         (save-restriction
>           (narrow-to-region beg end)
>
>           (goto-char (point-min))
>           (while (re-search-forward "_\\(.*\\)_" nil t)
>             (replace-match "\\\\textit{\\1}"))))
>
> You might probably solve the same issue by carefully tracking the
> lengthening of text — e.g. by incrementing ‘end’ by (- (length
> "\\\\textit{}") (length "__")) on each iteration — or by putting a
> marker at end and then passing that marker in re-search-forward. But
> narrowing is easier.

I recommend avoiding the use of narrowing as much as possible since it
can have other undesirable effects (e.g. it changes the result of
things like `syntax-ppss`).

There are indeed 2 "standard" solutions:
1- start your loop at the end, moving towards the beginning.
2- use a marker to keep track of the end.

You say "narrowing is easier", but using a marker is as simple as:

    (setq end (copy-marker end t))

so it's arguably simpler.


        Stefan




  reply	other threads:[~2021-05-08 13:53 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 23:06 replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-07  6:54 ` replace-regexp Tassilo Horn
2021-05-07 18:28   ` replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-08  0:02     ` replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-08  0:16       ` replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-08  5:38       ` replace-regexp Yuri Khan
2021-05-08 13:53         ` Stefan Monnier via Users list for the GNU Emacs text editor [this message]
2021-05-08 18:41           ` replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-08 18:50             ` replace-regexp Stefan Monnier via Users list for the GNU Emacs text editor
2021-05-08 21:59               ` replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-08 22:03                 ` replace-regexp Tassilo Horn
2021-05-08 22:25                   ` replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-08 22:54                     ` [External] : replace-regexp Drew Adams
2021-05-09  2:48             ` replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-08 18:46           ` replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-08 21:10             ` replace-regexp Stefan Monnier via Users list for the GNU Emacs text editor
2021-05-08 21:54               ` replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-08 23:11                 ` replace-regexp Stefan Monnier via Users list for the GNU Emacs text editor
2021-05-08 23:16                   ` replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-08 23:46                     ` replace-regexp Stefan Monnier via Users list for the GNU Emacs text editor
2021-05-08 23:51                       ` replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-09  7:38                       ` replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-08 22:59           ` avoid narrow-to-region (was: Re: replace-regexp) Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-09  5:48             ` Yuri Khan
2021-05-09  6:09               ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-09  6:34                 ` Yuri Khan
2021-05-09  6:59                   ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-09  7:22                     ` Jean Louis
2021-05-09  7:40                       ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-09 10:06                     ` Yuri Khan
2021-05-09 10:54                       ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-09 12:27                         ` Yuri Khan
2021-05-09 12:43                           ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-09 13:14                           ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-09 14:04                             ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-09 15:13                               ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-21 17:35                                 ` same sound random sort everywhere (was: Re: avoid narrow-to-region (was: Re: replace-regexp)) Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-21 20:12                                   ` Jean Louis
2021-05-21 20:47                                     ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-05-07  8:02 ` replace-regexp Jean Louis
2021-05-07 18:29   ` replace-regexp Emanuel Berg via Users list for the GNU Emacs text editor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvbl9l5o9l.fsf-monnier+emacs@gnu.org \
    --to=help-gnu-emacs@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.