From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Robert Pluim <rpluim@gmail.com>, emacs-devel@gnu.org
Subject: Re: master af0ea35ea0: Tweak how functions are formatted in Implementation in *Help*
Date: Sat, 02 Apr 2022 10:26:06 -0400 [thread overview]
Message-ID: <jwvbkxjlgp0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87h77bliwl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 02 Apr 2022 15:22:18 +0200")
>> If so, we should be careful to only apply it to the argnames but not to
>> the specializers since these are case sensitive.
> Yup. But, yes, I think it would make sense to upcase/italicize the
> argnames, because that would clarify what we're talking about here
> (which isn't at all obvious). Patches welcome.
Agreed.
>> The above patch also leads to odd results for methods with qualifiers.
>> E.g. `C-h o cl-generic-generalizers RET` shows things like:
>>
>> :extra "cl-struct" (cl-generic-generalizers type) in ‘cl-generic.el’.
>>
>> Undocumented
>>
>> which I find rather confusing.
>
> I've now made those things display as before, but I think it's not quite
> clear what that part is trying to express, so some clarification here
> would be nice.
The new behavior is weird/confusing. I get (with manual
capitalization, while we wait for an actual patch):
[...]
(cl-generic-generalizers (SPECIALIZER (head derived-mode))) in ‘cl-generic.el’.
Support for (derived-mode MODE) specializers.
Used internally for the (major-mode MODE) context specializers.
:extra "typeof" (TYPE) in ‘cl-generic.el’.
[...]
The presence/absence of `cl-generic-generalizers` looks rather
accidental/unexplained (IOW looks like a bug to me :-)
For reference, these correspond to:
(cl-defmethod cl-generic-generalizers ((specializer (head derived-mode))))
and
(cl-defmethod cl-generic-generalizers :extra "typeof" (type)
in the source code.
Stefan
next prev parent reply other threads:[~2022-04-02 14:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164872671963.30191.4037902323881017518@vcs2.savannah.gnu.org>
[not found] ` <20220331113841.3BBFAC0581F@vcs2.savannah.gnu.org>
2022-03-31 13:05 ` master af0ea35ea0: Tweak how functions are formatted in Implementation in *Help* Robert Pluim
2022-03-31 18:12 ` Stefan Monnier
2022-04-02 13:22 ` Lars Ingebrigtsen
2022-04-02 14:26 ` Stefan Monnier [this message]
2022-04-02 14:41 ` Lars Ingebrigtsen
2022-04-02 19:30 ` Stefan Monnier
2022-04-03 11:57 ` Lars Ingebrigtsen
2022-04-03 16:18 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbkxjlgp0.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.