From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 47b377f64b: Prevent non-local exits from ns-in-echo-area Date: Sun, 13 Nov 2022 10:18:48 -0500 Message-ID: References: <166830147947.13137.4061439325094811374@vcs2.savannah.gnu.org> <20221113010439.BF21DC00AB5@vcs2.savannah.gnu.org> <87tu33lfhk.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31039"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 13 16:19:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ouElO-0007qZ-M1 for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Nov 2022 16:19:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouEl9-00014K-2G; Sun, 13 Nov 2022 10:18:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouEl8-000149-3L for emacs-devel@gnu.org; Sun, 13 Nov 2022 10:18:58 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouEl6-0007xR-Lx for emacs-devel@gnu.org; Sun, 13 Nov 2022 10:18:57 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 48A648019D; Sun, 13 Nov 2022 10:18:55 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D7C918001A; Sun, 13 Nov 2022 10:18:49 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1668352729; bh=IWyGq/+GK0SMxWSI3wsgium+NILW3MKeo2Aj2CMS+FY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SCJo7Q5XtqJVmoROzraBbl1DziFG5KB3lUcuhgt25cphuSHZdGVtEgG57vUENqMdG fKktYIn1bhbt69XaG+LryZEJobtThYgtv5o78g9xL539V9hvQkxESJAURRAWqTnyhT M1Js1walK3Xl/T9Mbolmc/HoYzqLC8PPxU1vQ/k41fcT6sPjB2mFY3OjYddPh+/lgQ 3rPDOazjruzfIeXYGBvVmv09YoWU5EPG18FrSY0k8qhJHRyliNtRsCtB8Age1Vo4xq f2rF21oTtFflkntFjmWL+b9vWCqpCpJAuwo9whYxFtb4T2wXefg7+6OE57c4H4yJ3I 31Yoa1ft9VAoA== Original-Received: from pastel (unknown [104.247.241.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B4E991203CD; Sun, 13 Nov 2022 10:18:49 -0500 (EST) In-Reply-To: <87tu33lfhk.fsf@yahoo.com> (Po Lu's message of "Sun, 13 Nov 2022 11:07:03 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299725 Archived-At: > Okay. How about: > > Use safe_call so redisplay is inhibited, and internal_catch_all so > that the likes of `throw-on-input' or user advice can not cause a > non-local exit out of the Lisp function being called, both of which > are unsafe inside NS input callbacks. Fine by me, thanks, Stefan