From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59678: [PATCH] sh-script: use completion-table-with-cache to improve performance Date: Thu, 01 Dec 2022 15:30:04 -0500 Message-ID: References: <20221129143013.191469-1-yikai@z1k.dev> <83wn7bgm9y.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10031"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: yikai@z1k.dev, 59678@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 01 21:31:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0qDQ-0002MH-Sk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Dec 2022 21:31:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0qD2-0006Oj-1g; Thu, 01 Dec 2022 15:31:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0qD0-0006OU-Hp for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 15:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0qD0-0002TV-0m for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 15:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0qCz-0001TL-K4 for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 15:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Dec 2022 20:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59678 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59678-submit@debbugs.gnu.org id=B59678.16699266175652 (code B ref 59678); Thu, 01 Dec 2022 20:31:01 +0000 Original-Received: (at 59678) by debbugs.gnu.org; 1 Dec 2022 20:30:17 +0000 Original-Received: from localhost ([127.0.0.1]:41739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0qCH-0001T6-Gj for submit@debbugs.gnu.org; Thu, 01 Dec 2022 15:30:17 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0qCC-0001Sw-Bz for 59678@debbugs.gnu.org; Thu, 01 Dec 2022 15:30:16 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D29E6100134; Thu, 1 Dec 2022 15:30:06 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 14C5D100117; Thu, 1 Dec 2022 15:30:05 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1669926605; bh=UA66wGkFx41YYLpbpNSCRVx0Vfb1ue9U7Z+PywKMRWA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=E+Q6ScSK0bI88yAU1yuH6q5/ZMh6r3aPkZuWRuENLBd8gr+bcyrCvLZthoQWiIt1O qejVYq7uLXj/AirCj9pfwX6D3A77V9YWNxpLL/g6W2vwlymTAuS/3QnHuJpeJmjJih 0RN3U7C5GRayyeQmOMLDFoM0d3Cd77v9JW6+JfHHaNf0wCy0saoO1iNath7RRAhI7d dG/hiPgmaM+Iso2CXbZzzEVzLlWmpvPU8I3nWb/8J0+BiKKtoMC+o1gfrPxBgC20x6 O9eTs2+zCeUEkkJKzYGid8EMur0pA03aIjBOe52fCToelSJzAeVWODPKX3KQRQoEWS 8mK3ASDO1e0FQ== Original-Received: from pastel (unknown [45.72.193.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DFE401208FD; Thu, 1 Dec 2022 15:30:04 -0500 (EST) In-Reply-To: <83wn7bgm9y.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 01 Dec 2022 17:46:01 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249666 Archived-At: >> I found that the auto-completion on .sh files (with company-mode) was >> pretty slow (takes several seconds). It turns out that company-mode >> would call the capf function with 'metadata action for each >> candidate, where each function call would need to list all the >> cmds. In this patch, I modified the code to use >> completion-table-with-cache which fixes the problem for me. > > Stefan, any comments? Looks OK to me. The description of the problem looks concerning, tho: if Company really calls the completion table with `metadata` once per candidate, then there's a bug in company. Stefan