all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: kahatlen@gmail.com, Gregory Heytings <gregory@heytings.org>,
	60411@debbugs.gnu.org, juri@linkov.net
Subject: bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil
Date: Fri, 06 Jan 2023 12:51:41 -0500	[thread overview]
Message-ID: <jwvbknbmuad.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83pmbrvonx.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 06 Jan 2023 14:21:54 +0200")

>> > Then why not change that logic in minibuffer-next-completion to be 
>> > smarter about this?
>> I (and Stefan) already tried this, it doesn't seem to be feasible with a 
>> small and safe change.
> That's very surprising to hear.  AFAIU, it just looks for some special
> text property (in next-completion).  So it sounds like a very simple
> breakage of logic, where "next" means "the first one" when you are
> exactly at BOB.

The problem is how to determine "this is the first time".  Currently we
encode that information indirectly by the fact that point as at BOB
(and is not on an actual completion).

We could try and add a boolean buffer-local variable to remember if
we've already used `minibuffer-next-completion`.  Gregory said he tried
and bumped into further problems.  It would arguably be cleaner to do
that (and fix whichever other problem shows up), but I haven't had the
time to look into that.

I suspect in the mean time Gregory's hack might be an OK workaround
(invisible text tends to come with its own problems, so I'd prefer if
we install it conditionally rather than unconditionally, BTW), but
it should have a comment with a FIXME.


        Stefan






  parent reply	other threads:[~2023-01-06 17:51 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29 21:25 bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil Knut Anders Hatlen
2022-12-30  8:11 ` Eli Zaretskii
2022-12-30 11:04   ` Knut Anders Hatlen
2022-12-30 21:54 ` Gregory Heytings
2022-12-31  6:27   ` Knut Anders Hatlen
2022-12-31 15:02     ` Gregory Heytings
2022-12-31 15:33       ` Knut Anders Hatlen
2022-12-31 15:35         ` Gregory Heytings
2022-12-31 16:40       ` Eli Zaretskii
2023-01-01 17:00       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-01 17:05         ` Gregory Heytings
2023-01-01 17:55           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-01 18:56             ` Gregory Heytings
2023-01-05 17:37               ` Juri Linkov
2023-01-05 21:04                 ` Gregory Heytings
2023-01-06  6:43                   ` Eli Zaretskii
2023-01-06  8:22                     ` Gregory Heytings
2023-01-06  8:52                       ` Eli Zaretskii
2023-01-06  9:01                         ` Gregory Heytings
2023-01-06 11:40                           ` Eli Zaretskii
2023-01-06 12:13                             ` Gregory Heytings
2023-01-06 12:21                               ` Eli Zaretskii
2023-01-06 12:39                                 ` Gregory Heytings
2023-01-06 12:59                                   ` Eli Zaretskii
2023-01-06 13:10                                     ` Gregory Heytings
2023-01-06 13:26                                       ` Eli Zaretskii
2023-01-06 17:07                                         ` Gregory Heytings
2023-01-06 18:05                                           ` Eli Zaretskii
2023-01-06 18:23                                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-06 18:51                                               ` Gregory Heytings
2023-01-07 18:11                                           ` Juri Linkov
2023-01-07 18:15                                             ` Juri Linkov
2023-01-07 22:35                                               ` Gregory Heytings
2023-01-08  8:42                                                 ` Juri Linkov
2023-01-08 22:43                                                   ` Gregory Heytings
2023-01-12 17:48                                                 ` Juri Linkov
2023-01-06 17:51                                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-01-06 18:11                                   ` Eli Zaretskii
2023-01-06 18:49                                   ` Gregory Heytings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvbknbmuad.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=60411@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=gregory@heytings.org \
    --cc=juri@linkov.net \
    --cc=kahatlen@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.