From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67480: 30.0.50; Cannot start eglot Date: Tue, 28 Nov 2023 09:52:27 -0500 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28852"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67480@debbugs.gnu.org, Mou Tong To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 28 15:53:06 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r7zST-0007Fp-Ij for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Nov 2023 15:53:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r7zSP-0003mT-BM; Tue, 28 Nov 2023 09:53:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7zSK-0003m5-2e for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2023 09:52:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r7zSJ-0001PG-Me for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2023 09:52:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r7zSQ-0008O9-G8 for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2023 09:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Nov 2023 14:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67480 X-GNU-PR-Package: emacs Original-Received: via spool by 67480-submit@debbugs.gnu.org id=B67480.170118316532222 (code B ref 67480); Tue, 28 Nov 2023 14:53:02 +0000 Original-Received: (at 67480) by debbugs.gnu.org; 28 Nov 2023 14:52:45 +0000 Original-Received: from localhost ([127.0.0.1]:45923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7zS8-0008Ne-Vb for submit@debbugs.gnu.org; Tue, 28 Nov 2023 09:52:45 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7zS7-0008NR-0E for 67480@debbugs.gnu.org; Tue, 28 Nov 2023 09:52:43 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F3113442494; Tue, 28 Nov 2023 09:52:29 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1701183148; bh=ur006xhbFz/6xyPJwhMIGTVMUcMWR/9BSSC+XaNgUNA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=c/maN8g5TAY6JYUQJ/ZaNzuqXEbmHNwdmjZQWZfNWLcEv0zJpU9H67KZ9wf30Npzc BHpso2+qLaXMPoGWyckmqNhXXkbeJvzgqgKZre6rXnrREyShG12iUAa1MZxOUJhKWE rRlHDaZfKp9V0vVj/Ti9UFOid+FY071b2Y7Y0NQD3co/nfwlIh+uc+9xIzhNiAeqYp e79QQlczuLaeEL4laqLuEvJUUHLnrdV/q6bi74P6hTZQjquys4wU0Eq/I0BrY+sNux cyZo1azTFuikPZinCVikglGJsAeHNhN9tz6X57QJwOGXK7ncx/HS8jGkyFZ903e4Zr zJzXReddREzrw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CC72D442478; Tue, 28 Nov 2023 09:52:28 -0500 (EST) Original-Received: from pastel (unknown [45.72.194.97]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A65781202E4; Tue, 28 Nov 2023 09:52:28 -0500 (EST) In-Reply-To: (Mou Tong's message of "Mon, 27 Nov 2023 08:12:35 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275168 Archived-At: > 1. `emacs -Q` > 2. Open a src file and `M-x eglot` > 3. Get the following message: [...] > Loading external-completion (native compiled elisp)...done > Unbound slot: eglot-lsp-server, "# eglot-lsp-server-1feea1d8dd60>", -events-buffer, oref > error in process filter: Unbound slot: eglot-lsp-server, > "#", -events-buffer, oref > [2 times] > ``` [...] > After I tried to build different version, I can confirm the problem > occurs after this commit: > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D6c47931a1ad4de4a= f3f147b9604169c2441100fe Thanks, that was very helpful. This commit makes it so `:accessor` functions behave like `:reader` functions, i.e. behave like `slot-value`, whereas the old code returned nil if the slot was "unbound". Maybe the better fix is something like the patch below? Jo=E3o? Stefan diff --git a/lisp/jsonrpc.el b/lisp/jsonrpc.el index 52ffb220d8b..4298d75c5bf 100644 --- a/lisp/jsonrpc.el +++ b/lisp/jsonrpc.el @@ -71,6 +71,7 @@ jsonrpc-connection :accessor jsonrpc--request-continuations :documentation "A hash table of request ID to continuation lambdas.") (-events-buffer + :initform nil :accessor jsonrpc--events-buffer :documentation "A buffer pretty-printing the JSONRPC events") (-events-buffer-scrollback-size