From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: C-x v l does not move to current log entry Date: Fri, 10 Aug 2007 04:09:26 -0400 Message-ID: References: <46B03B75.4000008@swipnet.se> <18099.60849.120058.919034@rgrjr.dyndns.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1186733386 27024 80.91.229.12 (10 Aug 2007 08:09:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 10 Aug 2007 08:09:46 +0000 (UTC) Cc: esr@snark.thyrsus.com, rms@gnu.org, emacs-devel@gnu.org To: Bob Rogers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 10 10:09:44 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IJPYt-0002QJ-RR for ged-emacs-devel@m.gmane.org; Fri, 10 Aug 2007 10:09:36 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IJPYs-0002ZB-T8 for ged-emacs-devel@m.gmane.org; Fri, 10 Aug 2007 04:09:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IJPYp-0002Wu-ON for emacs-devel@gnu.org; Fri, 10 Aug 2007 04:09:31 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IJPYo-0002SJ-2M for emacs-devel@gnu.org; Fri, 10 Aug 2007 04:09:31 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IJPYn-0002S8-U4 for emacs-devel@gnu.org; Fri, 10 Aug 2007 04:09:29 -0400 Original-Received: from tomts40.bellnexxia.net ([209.226.175.97] helo=tomts40-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IJPYm-0006pQ-BV; Fri, 10 Aug 2007 04:09:28 -0400 Original-Received: from ceviche.home ([70.53.193.128]) by tomts40-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070810080927.UZFK29719.tomts40-srv.bellnexxia.net@ceviche.home>; Fri, 10 Aug 2007 04:09:27 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 15F5FB409D; Fri, 10 Aug 2007 04:09:26 -0400 (EDT) In-Reply-To: <18099.60849.120058.919034@rgrjr.dyndns.org> (Bob Rogers's message of "Fri\, 3 Aug 2007 23\:08\:33 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-Detected-Kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76315 Archived-At: > This turns out to be coming from log-view-font-lock-keywords, which has > a value that looks something like this: > ((eval \` (\,log-view-file-re (1 ...) (0 log-view-file-face append))) > (eval \` (\,log-view-message-re . log-view-message-face))) > The source (log-view.el:170) specifies backquoted forms inside a quoted > form; it appears that the reader is not handling this correctly. The > attached patch replaces the backquotes with explicit "cons" calls; this > is not a real fix, and I include it only to show that it does make the > error messages go away. Fixing the reader is undoubtedly hairier. It turns out that the handling of nested backquotes was simply not working. The reader's treatment worked (although IIRC it only works since Emacs-21), but the backquote expansion was flawed. As for the above bug it comes from an incorrect treatment of the new backquote style (and its nesting) in the printer (used by the byte-compiler, hence the above problem only appeared when using log-view.elc rather than log-view.el which is why it worked fine when I wrote the code). I believe I've now fixed both problems in the 22 branch (should be merged into the trunk in a couple days). Stefan "Duh!"