all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: bojohan+mail@dd.chalmers.se (Johan Bockgård)
Cc: emacs-pretest-bug@gnu.org
Subject: Re: vc-annotate bugs
Date: Tue, 21 Aug 2007 12:24:24 -0400	[thread overview]
Message-ID: <jwvabsknb39.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <yoijr6lxgokr.fsf@gamma02.me.chalmers.se> ("Johan Bockgård"'s message of "Tue\, 21 Aug 2007 12\:38\:12 +0200")

> The backtrace is

> Debugger entered--Lisp error: (beginning-of-buffer)
>   signal(beginning-of-buffer nil)
>   line-move-1(-1 nil nil)
>   line-move(-1 nil nil nil)
>   previous-line()
>   vc-annotate-warp-version("1.4")
>   vc-annotate-revision-previous-to-line()
>   call-interactively(vc-annotate-revision-previous-to-line)

Thanks.
I've installed the patch below in the 22 branch which should fix it.
I have not investigated the second bug yet, it's clearly related to VC
starting a second asynchronous process in the buffer before the first
process is finished.


        Stefan


--- vc.el	09 aoû 2007 10:33:12 -0400	1.424.2.5
+++ vc.el	21 aoû 2007 11:47:27 -0400	
@@ -3333,7 +3333,7 @@
                      vc-annotate-parent-display-mode
                      buf)
 	(goto-line (min oldline (progn (goto-char (point-max))
-				       (previous-line)
+				       (forward-line -1)
 				       (line-number-at-pos))) buf)))))
 
 (defun vc-annotate-compcar (threshold a-list)

  reply	other threads:[~2007-08-21 16:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-21 10:38 vc-annotate bugs Johan Bockgård
2007-08-21 16:24 ` Stefan Monnier [this message]
2008-01-05  5:26 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvabsknb39.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=bojohan+mail@dd.chalmers.se \
    --cc=emacs-pretest-bug@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.