reftex-mouse-view-crossref: change point?

reftex-mouse-view-crossref: change point?

[David Reitter]

Should functions like `reftex-mouse-view-crossref' really change the  
point?
This is isn't documented to do so, and in other GUIs, right (or shift- 
clicking) somewhere doesn't set the point either.


*** lisp/textmodes/reftex-dcr.el	25 Jul 2007 05:22:08 +0100	1.28.2.1
--- lisp/textmodes/reftex-dcr.el	15 Dec 2007 12:05:06 +0000	
***************
*** 231,238 ****
   If there is no such macro at point, search forward to find one.
   With argument, actually select the window showing the cross  
reference."
     (interactive "e")
!   (mouse-set-point ev)
!   (reftex-view-crossref current-prefix-arg))

   (defun reftex-view-crossref-when-idle ()
     ;; Display info about crossref at point in echo area or a window.
--- 231,239 ----
   If there is no such macro at point, search forward to find one.
   With argument, actually select the window showing the cross  
reference."
     (interactive "e")
!   (save-excursion
!     (mouse-set-point ev)
!     (reftex-view-crossref current-prefix-arg)))

   (defun reftex-view-crossref-when-idle ()
     ;; Display info about crossref at point in echo area or a window.

Re: reftex-mouse-view-crossref: change point?

[Ralf Angeli]

* David Reitter (2007-12-15) writes:

> Should functions like `reftex-mouse-view-crossref' really change the  
> point?

It should.  Otherwise the referencing macro might get out of view in
the original window and then one does not see the matching macros with
their contexts.

-- 
Ralf

Re: reftex-mouse-view-crossref: change point?

[David Reitter]

On 16 Dec 2007, at 07:49, Ralf Angeli wrote:
>>
>> Should functions like `reftex-mouse-view-crossref' really change the
>> point?
>
> It should.  Otherwise the referencing macro might get out of view in
> the original window and then one does not see the matching macros with
> their contexts.

That makes sense  - except when in configurations with pop-up-frames  
set to t (and similar customizations) the original window always stays  
the same. 

Re: reftex-mouse-view-crossref: change point?

[Stefan Monnier]

>> Should functions like `reftex-mouse-view-crossref' really change the  
>> point?

> It should.  Otherwise the referencing macro might get out of view in
> the original window and then one does not see the matching macros with
> their contexts.

Interesting detail, indeed.  Deserves a comment.


        Stefan