From: Stefan Monnier <monnier@iro.umontreal.ca>
To: rms@gnu.org
Cc: Magnus Henoch <mange@freemail.hu>, emacs-devel@gnu.org
Subject: Re: custom-mode should not be interactive
Date: Sun, 24 Feb 2008 15:34:28 -0500 [thread overview]
Message-ID: <jwvablq14ql.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1JTIh3-00027w-6p@fencepost.gnu.org> (Richard Stallman's message of "Sun, 24 Feb 2008 10:23:09 -0500")
> I'm not sure how to fix it though, as custom-mode is defined through
> define-derived-mode, which always makes the mode function interactive.
> One way is to define a new keyword argument for define-derived-mode.
> What do you think?
> I think it would be better not to use `define-derived-mode'.
> In fact, `custom-mode' is not derived from another mode.
Of course, I disagree.
As the Elisp manual states:
Even if the new mode is not an obvious derivative of any other mode,
it is convenient to use `define-derived-mode' with a `nil' parent
argument, since it automatically enforces the most important coding
conventions for you.
As for the OP's question, the manual also states (23.2.2 Major Mode
Conventions):
* Define a command whose name ends in `-mode', with no arguments,
that switches to the new mode in the current buffer. This command
so, it *should* be a "command", i.e. an interactive function.
The fact that it doesn't seem to do anything useful is not a problem.
As for the point number 2, we could address it by renaming the command to
customize-mode, although I'd just recommend partial-completion-mode
instead which helps just as well.
Stefan
next prev parent reply other threads:[~2008-02-24 20:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 0:33 custom-mode should not be interactive Magnus Henoch
2008-02-24 15:23 ` Richard Stallman
2008-02-24 20:34 ` Stefan Monnier [this message]
2008-02-27 21:27 ` Juri Linkov
2008-02-27 22:31 ` Stefan Monnier
2008-02-27 22:50 ` Juri Linkov
2008-02-28 1:50 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvablq14ql.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mange@freemail.hu \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.