From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 22.1.90; desktop-save throws (error "No buffer named ") Date: Wed, 27 Feb 2008 20:54:32 -0500 Message-ID: References: <92ve4aefit.fsf@nospam.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204163703 5103 80.91.229.12 (28 Feb 2008 01:55:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Feb 2008 01:55:03 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, Martin Fischer , emacs-devel@gnu.org To: "Juanma Barranquero" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 28 02:55:29 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JUXzZ-0008VG-Mk for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2008 02:55:26 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUXz2-0003qR-TL for ged-emacs-devel@m.gmane.org; Wed, 27 Feb 2008 20:54:52 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUXyy-0003pE-F6 for emacs-devel@gnu.org; Wed, 27 Feb 2008 20:54:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUXyw-0003ny-FV for emacs-devel@gnu.org; Wed, 27 Feb 2008 20:54:47 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUXyw-0003nk-Ak for emacs-devel@gnu.org; Wed, 27 Feb 2008 20:54:46 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JUXyp-0004bM-RF; Wed, 27 Feb 2008 20:54:40 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao8CAC+jxUdMCpz5Wmdsb2JhbACQXgEgnhWBAg X-IronPort-AV: E=Sophos;i="4.25,416,1199682000"; d="scan'208";a="15326295" Original-Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 27 Feb 2008 20:54:37 -0500 Original-Received: from pastel.home ([76.10.156.249]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id IDE61336; Wed, 27 Feb 2008 20:54:36 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 406B37F25; Wed, 27 Feb 2008 20:54:32 -0500 (EST) In-Reply-To: (Juanma Barranquero's message of "Thu, 28 Feb 2008 00:00:57 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:90682 gmane.emacs.pretest.bugs:21327 Archived-At: >> No, the whole point of the function is to provide a meaningful >> functionality independently from desktop.el. > As there are no other users, we don't know if it is more useful and > general to return nil for empty basenames or to return "". We know that one is meaningful: it indicates that the buffer name *is* under uniquify's control. >> Exactly: *to desktop* this is so, but not in general, so the test >> belongs in desktop.el. > There are no general uses of `uniquify-buffer-base-name'. There is no > general definition of a "base name", it is an internal thing of > uniquify; It's not linked to its implementation but to its featureset, so it's "specific" to uniquify, but not "internal". Which is why it's a good interface which stands on its own, whether or not desktop.el is its only user. Please undo your change to uniquify and move the test to desktop.el. Stefan