From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.60; Resizing may delete windows Date: Thu, 03 Apr 2008 16:52:00 -0400 Message-ID: References: <47E42196.8010302@gmail.com> <47E9347C.5000905@gmail.com> <47E94B35.4080507@gmx.at> <47E95C8F.4050604@gmail.com> <47E9783C.8060406@gmx.at> <47E9FDD2.4010205@gmx.at> <47EA83A7.9000305@gmx.at> <47EACE96.8020805@gmx.at> <47EB51BE.5060602@gmx.at> <47F34748.1020604@gmx.at> <47F3BC98.7060707@gmx.at> <47F4ED1C.5010905@gmx.at> <47F4F594.50500@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1207255984 12489 80.91.229.12 (3 Apr 2008 20:53:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Apr 2008 20:53:04 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, "Jan D." , "Lennart Borgman \(gmail\)" , Michael Kifer To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 03 22:53:36 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JhWRD-0007vt-Pj for ged-emacs-devel@m.gmane.org; Thu, 03 Apr 2008 22:53:36 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JhWQb-0001QW-5Q for ged-emacs-devel@m.gmane.org; Thu, 03 Apr 2008 16:52:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JhWPt-00015F-MS for emacs-devel@gnu.org; Thu, 03 Apr 2008 16:52:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JhWPq-00013g-8f for emacs-devel@gnu.org; Thu, 03 Apr 2008 16:52:12 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JhWPq-00013c-2O for emacs-devel@gnu.org; Thu, 03 Apr 2008 16:52:10 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JhWPq-00045w-2x for emacs-devel@gnu.org; Thu, 03 Apr 2008 16:52:10 -0400 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JhWPp-0007ij-AX for emacs-pretest-bug@gnu.org; Thu, 03 Apr 2008 16:52:09 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JhWPl-00044i-Ck for emacs-pretest-bug@gnu.org; Thu, 03 Apr 2008 16:52:09 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182] helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JhWPl-00044Q-2z for emacs-pretest-bug@gnu.org; Thu, 03 Apr 2008 16:52:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AloCAJrf9EfO+J/WdGdsb2JhbACBWo97ASqaOQ X-IronPort-AV: E=Sophos;i="4.25,600,1199682000"; d="scan'208";a="17560213" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 03 Apr 2008 16:52:00 -0400 Original-Received: from pastel.home ([206.248.159.214]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id JYD94500; Thu, 03 Apr 2008 16:52:00 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 7E38B7FEE; Thu, 3 Apr 2008 16:52:00 -0400 (EDT) In-Reply-To: <47F4F594.50500@gmx.at> (martin rudalics's message of "Thu, 03 Apr 2008 17:19:48 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:94280 gmane.emacs.pretest.bugs:21856 Archived-At: >> Right, but in your message you referred to 1 and 2, rather than to >> window-min-(height|width). As far as I can tell, we're discussing >> window resizing which is only affected by window-min-(height|width). >> MIN_SAFE_WINDOW_(HEIGHT|WIDTH) only affect window-min-(height|width), so >> it only affects resizing in a very indirect manner (e.g. we can scan >> all windows, reset window-min-(height|width) to valid values and the >> resize without paying attention to MIN_SAFE_WINDOW_(HEIGHT|WIDTH)). > shrink_windows is called with a min_size argument of 1 if shrinking > heights. That's all I can observe. When I put a breakpoint on shrink_windows, I see it gets called with a min_size of 4 (and width_p is 0). I.e. it gets called with the value of window-min-height, just as it should. >> Yes, but I do use 1-line-high windows, and disallowing them just because >> we can't be bothered to write the window-resize code in the right way >> isn't the right answer. > That's why shrink_windows would have to check for every window whether > it has a modeline and not resize it if it has one and its actual height > is 2. I still do not understand what modelines have to do with it. Stefan