New global bindings

New global bindings

[Stefan Monnier]

I have some problems with the new global bindings for C--, C-=, and C-+:
1- they're not mentioned in etc/NEWS (it seems none of the face-remap
    feature is mentioned there).
2- (control -) was used for negative prefix arguments, so this is
    a significant change for oldtimers.
3- these are very short key-bindings for a feature that does not seem to
   require them: you're unlikely to want to do it that frequently.

Point nb 1 is easy to fix, maybe I can live with nb 3, but nb 2 seems to
be more problematic.  So I think we need to find some other key-bindings
for that.  I think a prefix key followed by +, -, and = (repeatable like
C-x e e e e e, maybe even allowing switching between + and -) is the
best choice.


        Stefan

Re: New global bindings

[Miles Bader]

Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I have some problems with the new global bindings for C--, C-=, and C-+:
> 1- they're not mentioned in etc/NEWS (it seems none of the face-remap
>     feature is mentioned there).
> 2- (control -) was used for negative prefix arguments, so this is
>     a significant change for oldtimers.
> 3- these are very short key-bindings for a feature that does not seem to
>    require them: you're unlikely to want to do it that frequently.
>
> Point nb 1 is easy to fix, maybe I can live with nb 3, but nb 2 seems to
> be more problematic.  So I think we need to find some other key-bindings
> for that.  I think a prefix key followed by +, -, and = (repeatable like
> C-x e e e e e, maybe even allowing switching between + and -) is the
> best choice.

I used those particulars bindings are because lots of other popular apps
use them for this purpose (offhand, gnome apps and firefox, but
certainly more than that).

GIven that there about 47 different ways to enter a negative prefix
argument, and this one can't even be used on terminals -- so _real_ old
timers probably won't use it -- is point (2) really such a big deal?

-Miles

-- 
The key to happiness
 is having dreams.      [from a fortune cookie]

Re: New global bindings

[M Jared Finder]

Stefan Monnier wrote:
> I have some problems with the new global bindings for C--, C-=, and C-+:
> 1- they're not mentioned in etc/NEWS (it seems none of the face-remap
>     feature is mentioned there).
> 2- (control -) was used for negative prefix arguments, so this is
>     a significant change for oldtimers.
> 3- these are very short key-bindings for a feature that does not seem to
>    require them: you're unlikely to want to do it that frequently.
> 
> Point nb 1 is easy to fix, maybe I can live with nb 3, but nb 2 seems to
> be more problematic.  So I think we need to find some other key-bindings
> for that.  I think a prefix key followed by +, -, and = (repeatable like
> C-x e e e e e, maybe even allowing switching between + and -) is the
> best choice.

As a user, I agree very much with this sentiment.  Very few editors even 
support C-+/C-- zooming; that's generally a viewer binding.  I would be 
happy with C-x C-+/C-x C-- bindings.

   -- MJF

Re: New global bindings

[Eric Hanchrow]

I like the idea of C-- reducing the font, and C-+ enlarging it, thus
making Emacs more like other apps.
-- 
... a physicist of my acquaintance confiscated my copies of The
Tao of Physics and The Dancing Wu-li Masters and wouldn't let me have
them back even when I threatened to sue.
        -- Megan McArdle (writing as "Jane Galt")

RE: New global bindings

[Drew Adams]

> > I have some problems with the new global bindings for C--, 
> > C-=, and C-+: 1- they're not mentioned in etc/NEWS (it
> >     seems none of the face-remap feature is mentioned there).
> > 2- (control -) was used for negative prefix arguments, so this is
> >     a significant change for oldtimers.
> > 3- these are very short key-bindings for a feature that 
> >     does not seem to require them: you're unlikely to want to do
> >     it that frequently.
> > 
> > Point nb 1 is easy to fix, maybe I can live with nb 3, but 
> > nb 2 seems to be more problematic.  So I think we need to
> > find some other key-bindings for that.  I think a prefix key
> > followed by +, -, and = (repeatable like C-x e e e e e, maybe
> > even allowing switching between + and -) is the best choice.
> 
> As a user, I agree very much with this sentiment.  Very few 
> editors even support C-+/C-- zooming; that's generally a viewer
> binding. I would be happy with C-x C-+/C-x C-- bindings.

I agree, and I already said the same thing.

There is no need to co-opt such short keys, especially a key (`C--') that is
already bound and very useful. Please use a repeatable prefix key, as suggested,
if you make any key bindings at all for this.

Please do one of the following:

1. Don't bind any keys in this library. Include binding
   suggestions in the Commentary, if you like.
2. Bind keys only in a minor-mode map.

Re: New global bindings

[Paul R]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Point nb 1 is easy to fix, maybe I can live with nb 3, but nb 2 seems to
> be more problematic.  So I think we need to find some other key-bindings
> for that.  I think a prefix key followed by +, -, and = (repeatable like
> C-x e e e e e, maybe even allowing switching between + and -) is the
> best choice.

It is one more case where I think emacs should provide a binding of
the form C-x C-+ + + + + ...

'+' would mean "repeat last command" as long as no other key is hit.
Additionnaly, we could declare "-" as a valid candidate.
Why not :

(global-set-key-autorepeat '("\C-x\C-" . ("+" . zoom-in)
                                         ("-" . zoom-out)))

to allow auto-repeat on + and - after either C-x C-- or C-x C-+. 

I'd be happy if emacs could provide a primitive for this. It could
display a transient helper in the echo area to remind what keys are
temporary bound to special functions.

Currently, I use the following code :

;;;; Auto-repeat any command by pressing last shortcut key
(defun auto-repeat-command (command)
  (let ((repeat-repeat-char
         (when (eq last-command-char
                   last-command-event)
           last-command-char)))
    (call-interactively command)
    (while (eq (read-event) repeat-repeat-char)
      ;; Make each repetition undo separately.
      (auto-repeat-command command)
      (setq unread-command-events (list last-input-event)))))


then, for example :

(global-set-key "\C-xmn" (lambda () (interactive) (auto-repeat-command 'marker-visit-next)))

This is clearly not optimal, but it works and I have not looked for a
cleaner implementation, yet.

This type of binding is ideal for any command that :
 - is not very often called
 - when called, will probably be called several time in a row
They are a lot of places where such default behaviour would provide
intuitive and non-intrusive bindings.

What do you think ?

-- 
      Paul

Re: New global bindings

[joakim]

Miles Bader <miles@gnu.org> writes:


> I used those particulars bindings are because lots of other popular apps
> use them for this purpose (offhand, gnome apps and firefox, but
> certainly more than that).

I have really missed this feature, so thanks! Finally I can easily show
code to co-workers, and type messages to my son.

Some notes:

- A prefix, repeatable, keybinding like Stefan suggested would be quite
ok for usage. When you change font size, you want to conveniently find
the right one, but you dont want to do it all the time.

- try opening face-remap.el, and make the font really really small.
On line 180, as well as other places,  indentation becomes weird,
probably because tab-width is being computed wrongly or something.


-- 
Joakim Verona

Re: New global bindings

[Miles Bader]

joakim@verona.se writes:
> - try opening face-remap.el, and make the font really really small.
> On line 180, as well as other places,  indentation becomes weird,
> probably because tab-width is being computed wrongly or something.

If I recall correctly, there's currently a single tab "basis" (the
character width which buffer tab-widths are a multiple of) for the
entire frame.  This can also be noticed if you use tabs in text covered
by an explicit face property (and in the past, sometimes changing the
frame font didn't update it properly, leading to similarly weird
effects).

It should really be calculated dynamically.  I've been meaning to look
into fixing this.

-Miles

-- 
Genealogy, n. An account of one's descent from an ancestor who did not
particularly care to trace his own.

Re: New global bindings

[Miles Bader]

"Drew Adams" <drew.adams@oracle.com> writes:
> 1. Don't bind any keys in this library. Include binding
>    suggestions in the Commentary, if you like.

That is clearly unacceptable.

-Miles

-- 
Dictionary, n.  A malevolent literary device for cramping the growth of
a language and making it hard and inelastic. This dictionary, however,
is a most useful work.

Re: New global bindings

[Miles Bader]

M Jared Finder <jared@hpalace.com> writes:
> I would be happy with C-x C-+/C-x C-- bindings.

Please try the following:

(define-key ctl-x-map [(control ?+)] 'incdec-buffer-face-height)
(define-key ctl-x-map [(control ?-)] 'incdec-buffer-face-height)
(define-key ctl-x-map [(control ?=)] 'incdec-buffer-face-height)
(define-key ctl-x-map [(control ?0)] 'incdec-buffer-face-height)

(defun incdec-buffer-face-height (&optional inc)
  "Increase or decrease the height of the default face in the current buffer.

Then, continue to read input events and increase/decrease the
face height as long as the input events with all modifiers
removed are one of the following:

   +, =   Increase the default face height by one step
   -      Decrease the default face height by one step
   0      Reset the default face height to the global default

Each step scales the height of the default face by the variable
`text-scale-mode-step' (a negative number of steps decreases the
height by the same amount).  As a special case, an argument of 0
will remove any scaling currently active.

This command is a special-purpose wrapper around the
`increase-buffer-face-height' command which makes repetition
convenient even when it is bound in a non-top-level keymap.  For
binding in a top-level keymap, `increase-buffer-face-height' or
`decrease-default-face-height' may be more appropriate."
  (interactive "p")
  (let ((first t) 
	(step t)
	(ev last-command-event))
    (while step
      (let ((base (event-basic-type ev)))
	(cond ((or (eq base ?+) (eq base ?=))
	       (setq step inc))
	      ((eq base ?-)
	       (setq step (- inc)))
	      ((eq base ?0)
	       (setq step 0))
	      (first 
	       (setq step inc))
	      (t
	       (setq step nil))))
      (when step
	(increase-buffer-face-height step)
	(setq inc 1 first nil)
	(setq ev (read-event))))
    (push ev unread-command-events)))


Thanks,

-Miles

-- 
Education, n. That which discloses to the wise and disguises from the foolish
their lack of understanding.

Re: New global bindings

[Stefan Monnier]

>> I would be happy with C-x C-+/C-x C-- bindings.
> Please try the following:

Looks good.  Could you be careful with the namespaces, tho?
E.g. use a "face-remap-" prefix for things in face-remap.el or something
like that?


        Stefan

Re: New global bindings

[Miles Bader]

Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Looks good.  Could you be careful with the namespaces, tho?
> E.g. use a "face-remap-" prefix for things in face-remap.el or something
> like that?

I prefer to use traditional elisp/lisp naming conventions.

-Miles

-- 
"Whatever you do will be insignificant, but it is very important that
 you do it."  Mahatma Gandhi

Re: New global bindings

[Stefan Monnier]

>> Looks good.  Could you be careful with the namespaces, tho?
>> E.g. use a "face-remap-" prefix for things in face-remap.el or something
>> like that?

> I prefer to use traditional elisp/lisp naming conventions.

That's a good convention for core functionality, but it the lack of
namespace support in Elisp makes it desirable to carefully use prefixes
for everything else.

Of course, you may call your rescaler "core-functionality", but I'd tend
to only include in "core functionality" things that are closer to
"libraries" than to "user commands".


        Stefan

Re: New global bindings

[joakim]

Seems to work nicely, thanks!

Caveats:

- Why is "=" bound to the same as "+"?
Is it because of the kbd layout you use?

- Could there be menu entries to help find this feature?

- "c-x c-+ +" also increases height. Is that desired?

- should c-g exit and restore default size?

- "c-x c-+ p" exits size change as expected, but leaves
a confusing "c-x c-+ p" message in the minibuffer.

- a message similar to "c-x e" "type 'e' to repeat macro" would be nice

Thanks again for this useful feature!


Miles Bader <miles.bader@necel.com> writes:

> M Jared Finder <jared@hpalace.com> writes:
>> I would be happy with C-x C-+/C-x C-- bindings.
>
> Please try the following:
>
> (define-key ctl-x-map [(control ?+)] 'incdec-buffer-face-height)
> (define-key ctl-x-map [(control ?-)] 'incdec-buffer-face-height)
> (define-key ctl-x-map [(control ?=)] 'incdec-buffer-face-height)
> (define-key ctl-x-map [(control ?0)] 'incdec-buffer-face-height)
>
...

>
> Thanks,
>
> -Miles
-- 
Joakim Verona

Re: New global bindings

[Miles Bader]

joakim@verona.se writes:
> - Why is "=" bound to the same as "+"?
> Is it because of the kbd layout you use?

Because that's a fairly common binding (e.g., firefox) -- "+" is a
shifted key on U.S. keyboard layouts, but "=" is the same key unshifted,
and is next to the "-" key.  So for convenient use, "-" and "=" actually
make a good pair.

> - Could there be menu entries to help find this feature?

Dunno

> - "c-x c-+ +" also increases height. Is that desired?

Seems ok to me.

> - should c-g exit and restore default size?

I don't really know, but offhand I don't think so -- it's not really
supposed to seem like you're in some little "mode", but rather give the
impression that you're repeating the command without needing to type
C-x.

> - "c-x c-+ p" exits size change as expected, but leaves
> a confusing "c-x c-+ p" message in the minibuffer.

I don' t know how to control the funny echo-area messages for prefix keys.

-miles

-- 
Yo mama's so fat when she gets on an elevator it HAS to go down.

Re: New global bindings

[Juanma Barranquero]

Testing face-remap with linum-mode, a small limitation does show up:
margin width is computed in character cells (according to the docs of
`set-window-margins'), but obviously it does not take
`face-remapping-alist' into account.

 Juanma

Re: New global bindings

[Stephen Berman]

On Wed, 4 Jun 2008 16:35:41 +0200 "Juanma Barranquero" <lekktu@gmail.com> wrote:

> Testing face-remap with linum-mode, a small limitation does show up:
> margin width is computed in character cells (according to the docs of
> `set-window-margins'), but obviously it does not take
> `face-remapping-alist' into account.

This also reveals a linum bug: linum-mode fails to update the display
when the font size changes.  E.g., with linum-mode enabled type C-x C--
and then there is text at the bottom of the the window with no line
numbering in the margin (if the text in the buffer is long enough).

Steve Berman