From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [patch] vc-find-root with invert Date: Fri, 04 Jul 2008 14:02:01 -0400 Message-ID: References: <486E5CE0.5090004@justinbogner.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1215194538 21691 80.91.229.12 (4 Jul 2008 18:02:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Jul 2008 18:02:18 +0000 (UTC) Cc: emacs-devel@gnu.org To: Justin Bogner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 04 20:03:04 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KEpcc-00055n-VI for ged-emacs-devel@m.gmane.org; Fri, 04 Jul 2008 20:03:03 +0200 Original-Received: from localhost ([127.0.0.1]:59366 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEpbm-0005C5-9E for ged-emacs-devel@m.gmane.org; Fri, 04 Jul 2008 14:02:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KEpbh-0005Be-Uc for emacs-devel@gnu.org; Fri, 04 Jul 2008 14:02:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KEpbg-0005Aj-Cq for emacs-devel@gnu.org; Fri, 04 Jul 2008 14:02:05 -0400 Original-Received: from [199.232.76.173] (port=44626 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEpbg-0005AY-8X for emacs-devel@gnu.org; Fri, 04 Jul 2008 14:02:04 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:5641 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KEpbf-0001lX-HS for emacs-devel@gnu.org; Fri, 04 Jul 2008 14:02:03 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AsoEAHcCbkhFxIdG/2dsb2JhbACBXK5DggE X-IronPort-AV: E=Sophos;i="4.30,303,1212379200"; d="scan'208";a="23971943" Original-Received: from 69-196-135-70.dsl.teksavvy.com (HELO pastel.home) ([69.196.135.70]) by ironport2-out.teksavvy.com with ESMTP; 04 Jul 2008 14:02:01 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id B7FAE8EAD; Fri, 4 Jul 2008 14:02:01 -0400 (EDT) In-Reply-To: <486E5CE0.5090004@justinbogner.com> (Justin Bogner's message of "Fri, 04 Jul 2008 11:24:48 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100349 Archived-At: > Here's a patch that fixes a bug I've noticed in vc-find-root. When called > with `invert' equal to `t', the current implementation is returning `file' > verbatim if a file name is given, and also if `witness' doesn't exist > at all. Can someone remind me why we have this `invert' monster? Stefan