From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Andreas Schwab <schwab@suse.de>
Cc: emacs-devel@gnu.org
Subject: tar-mode shouldn't use write-contents-functions
Date: Thu, 01 Jan 2009 12:29:40 -0500 [thread overview]
Message-ID: <jwvababos2c.fsf-monnier+emacs@gnu.org> (raw)
Could you explain your latest change to tar-mode:
;;; tar-mode.el --- simple editing of tar files from GNU emacs
----------------------------
revision 1.133
date: 2008-12-31 04:58:53 -0500; author: schwab; state: Exp; lines: +13 -10; commitid: bktiZYl153iysBwt;
(tar-mode): Set write-contents-functions instead of
write-region-annotate-functions.
(tar-mode-write-contents): New function.
(tar-write-region-annotate): Remove.
----------------------------
This seems to basically undo my earlier change:
revision 1.128
date: 2008-05-28 13:43:58 -0400; author: monnier; state: Exp; lines: +15 -22; commitid: vJEploj5uzkA0L4t;
(tar-summarize-buffer): Fix reporter initialization.
(tar-mode): Use write-region-annotate-functions rather than
write-contents-functions.
(tar-extract): Remove unused var `pos'.
(tar-subfile-save-buffer): Remove unused var `following-descs'.
(tar-mode-write-file): Remove.
(tar-write-region-annotate): New function.
----------------------------
Could you explain the reason for it? IIUC your change causes (among
other things) auto-save to fail (it saves the summary rather than the
raw tar data).
Stefan
next reply other threads:[~2009-01-01 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-01 17:29 Stefan Monnier [this message]
2009-01-01 17:40 ` tar-mode shouldn't use write-contents-functions Andreas Schwab
2009-01-01 20:46 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvababos2c.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.