From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4981: C-l during query-replace Date: Mon, 30 Nov 2009 09:13:52 -0500 Message-ID: References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> <873a49ad0f.fsf@mail.jurta.org> <87fx7w7v6p.fsf@mail.jurta.org> <200911300629.nAU6Txdn009909@godzilla.ics.uci.edu> Reply-To: Stefan Monnier , 4981@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1259591554 4175 80.91.229.12 (30 Nov 2009 14:32:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 30 Nov 2009 14:32:34 +0000 (UTC) Cc: 4981@emacsbugs.donarmstrong.com To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 30 15:32:27 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NF7Ig-0001fY-QR for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Nov 2009 15:32:27 +0100 Original-Received: from localhost ([127.0.0.1]:57836 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF7Ig-0004fG-EB for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Nov 2009 09:32:26 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NF7Dv-000297-Iy for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 09:27:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NF7Dq-00026A-7t for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 09:27:30 -0500 Original-Received: from [199.232.76.173] (port=48939 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF7Dp-00025x-UF for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 09:27:25 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:57493) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NF7Dp-0005O6-JA for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 09:27:25 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUERNNc017038; Mon, 30 Nov 2009 06:27:23 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAUEK4uA016226; Mon, 30 Nov 2009 06:20:04 -0800 Resent-Date: Mon, 30 Nov 2009 06:20:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 30 Nov 2009 14:20:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4981 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4981-submit@emacsbugs.donarmstrong.com id=B4981.125959044015742 (code B ref 4981); Mon, 30 Nov 2009 14:20:04 +0000 Original-Received: (at 4981) by emacsbugs.donarmstrong.com; 30 Nov 2009 14:14:00 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUEDwUQ015736 for <4981@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 06:14:00 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AroEAPZhE0tFpYc//2dsb2JhbACBTtVThDEEihmDDg X-IronPort-AV: E=Sophos;i="4.47,314,1257138000"; d="scan'208";a="50322603" Original-Received: from 69-165-135-63.dsl.teksavvy.com (HELO pastel.home) ([69.165.135.63]) by ironport2-out.pppoe.ca with ESMTP; 30 Nov 2009 09:13:52 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 341BBEB978; Mon, 30 Nov 2009 09:13:52 -0500 (EST) In-Reply-To: <200911300629.nAU6Txdn009909@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 29 Nov 2009 22:29:59 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Mon, 30 Nov 2009 09:27:30 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33067 Archived-At: > Thanks for fixing this. Are you sure that the new `recenter-positions' > is needed? Given that there are 3 choices, it's easy to cycle through > them, so adding yet another defcustom that would be use by a very small > number of users does not seem justified (IMHO). I agree that it's overengineering. This patch is only acceptable if (to compensate) it unifies the two duplicate code paths of move-to-window-line-top-bottom and recenter-top-bottom. Stefan