all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: 4981@emacsbugs.donarmstrong.com
Subject: bug#4981: C-l during query-replace
Date: Mon, 30 Nov 2009 09:13:52 -0500	[thread overview]
Message-ID: <jwvaay45cfa.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <200911300629.nAU6Txdn009909@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 29 Nov 2009 22:29:59 -0800 (PST)")

> Thanks for fixing this.  Are you sure that the new `recenter-positions'
> is needed?  Given that there are 3 choices, it's easy to cycle through
> them, so adding yet another defcustom that would be use by a very small
> number of users does not seem justified (IMHO).

I agree that it's overengineering.  This patch is only acceptable if
(to compensate) it unifies the two duplicate code paths of
move-to-window-line-top-bottom and recenter-top-bottom.


        Stefan





  parent reply	other threads:[~2009-11-30 14:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87skbwt9xq.fsf@mail.jurta.org>
2009-11-20  0:16 ` bug#4981: C-l during query-replace Dan Nicolaescu
2009-11-20  9:29   ` Juri Linkov
2009-11-29 23:44     ` Juri Linkov
2009-11-30  1:28       ` Stefan Monnier
2009-11-30  6:29       ` Dan Nicolaescu
2009-11-30 11:12         ` Juanma Barranquero
2009-11-30 12:04           ` Juri Linkov
2009-11-30 14:13         ` Stefan Monnier [this message]
2009-11-30 16:07           ` Juri Linkov
2009-11-30 17:24             ` Drew Adams
2009-11-30 20:55             ` Stefan Monnier
2009-11-30 16:30   ` bug#4981: marked as done (C-l during query-replace) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvaay45cfa.fsf-monnier+emacsbugreports@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=4981@emacsbugs.donarmstrong.com \
    --cc=dann@ics.uci.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.