bug#5627: 23.1.90; outline-regexp ignores customization

bug#5627: 23.1.90; outline-regexp ignores customization

[Andreas Roehler]

Hi,

edebug displayed: outline-regexp as delivered is used
after customization still. Also if custom-file was
loaded from my daily Emacs.

Checked with emacs -Q

Setting was: (\|[A-Z]

Thanks all

Andreas

--
https://code.launchpad.net/~a-roehler/python-mode
https://code.launchpad.net/s-x-emacs-werkstatt/

;;;;;;;;;;;;;;;

In GNU Emacs 23.1.92.1 (i686-pc-linux-gnu, GTK+ Version 2.12.0)
 of 2010-02-19
Windowing system distributor `The X.Org Foundation', version 11.0.70200000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
m <tab> o <tab> <return> M-x h i d e - b o <tab> <return>
M-x <up> <up> <right> <right> <right> <right> <right>
<right> <right> <right> m i n o r - <return> M-x <up>
<up> <return> <next> <next> M-x r e v e r <tab> t -
b <tab> <return> y e s <return> M-x <up> <up> <up>
<return> C-c C-t M-x <up> <up> <up> <return> M-< M-x
s h o w - a l <tab> <return> M-x c o t <backspace>
s t u <tab> <backspace> <tab> <backspace> <backspace>
<backspace> u s t o m <tab> - v a r <tab> <return>
o u t l i <tab> - <backspace> r e g <tab> <return>
<help-echo> <help-echo> <down-mouse-1> <help-echo>
<mouse-1> <help-echo> <backspace> <backspace> A - Z
<left> <left> <left> <left> <right> <right> <right>
<right> <help-echo> <help-echo> <help-echo> <down-mouse-1>
<mouse-1> <help-echo> <help-echo> <return> M-+ C-x
b <return> M-x <up> <up> <up> <return> M-x <up> <up>
<up> <up> <up> <up> <return> y e s <return> M-x <up>
<up> <return> M-x <up> <up> C-k s h o w - a l l <tab>
<return> <next> <next> <next> <next> C-x b <return>
<down> <down> <down> <right> <right> <right> <right>
<right> <right> <right> <right> <right> <right> <right>
<right> <right> <right> <right> <right> <right> <right>
<right> <right> <right> <right> <right> <right> <right>
<right> <right> <right> C \ | <help-echo> <help-echo>
<down-mouse-1> <mouse-1> <down> <down> <down> <right>
<right> <right> <right> <right> <right> <right> <right>
<right> <right> <right> <right> <right> <right> <right>
<right> <right> <right> <right> <right> <right> <right>
<right> <right> <right> <right> <right> <right> <right>
<right> <right> <right> C-d ( <help-echo> <help-echo>
<help-echo> <help-echo> <down-mouse-1> <mouse-1> <help-echo>
C-x b <return> M-x <up> <up> <return> M-< M-x r e p
a o r t <backspace> <backspace> <backspace> <backspace>
o r t - e m <tab> <return>

Recent messages:
Making completion list...
Outline minor mode enabled
Making completion list...
Outline minor mode enabled
Mark set
Creating customization items...
Creating customization items ...done
Resetting customization items...done
Creating customization setup...done
Mark set

Load-path shadows:
None found.

Features:
(shadow sort mail-extr message sendmail regexp-opt ecomplete rfc822 mml
mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse
rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util
netrc time-date mm-util mail-prsvr gmm-utils mailheader canlock sha1
hex-util hashcash mail-utils emacsbug help-fns cus-edit cus-start
cus-load wid-edit noutline outline easy-mmode help-mode easymenu view
tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd
font-setting tool-bar dnd fontset image fringe lisp-mode register page
menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button
minibuffer faces cus-face files text-properties overlay md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind system-font-setting
font-render-setting gtk x-toolkit x multi-tty emacs)

bug#5627: 23.1.90; outline-regexp ignores customization

[Andreas Roehler]

Hi,

C-h v outline-regexp:

outline-regexp is a variable defined in `outline.el'.
Its value is
";;;\\(;* [^ 	\n]\\|###autoload\\)\\|("
Local in buffer ar-thing-at-point-utils-intern.el; global value is "(\\|[A-Z]"

It indicates, customization is taken only globally.

BTW ar-thing-at-point-utils-intern.el has no local vars defined.

Cheers

Andreas

bug#5627: 23.1.90; outline-regexp ignores customization

[Glenn Morris]

Andreas Röhler wrote (on Tue, 23 Feb 2010 at 12:51 +0100):

> C-h v outline-regexp:
> 
> outline-regexp is a variable defined in `outline.el'.
> Its value is
> ";;;\\(;* [^ 	\n]\\|###autoload\\)\\|("
> Local in buffer ar-thing-at-point-utils-intern.el; global value is "(\\|[A-Z]"

Yes, some modes such as emacs-lisp-mode make buffer-local settings of
outline-regexp, since the value is likely to be very dependent on the
type of file.

As it says in the documentation of that variable:

  The recommended way to set this is with a Local Variables: list
  in the file it applies to.

Or use a mode-hook.

bug#5627: 23.1.90; outline-regexp ignores customization

[Andreas Roehler]

Glenn Morris wrote:
> Andreas Röhler wrote (on Tue, 23 Feb 2010 at 12:51 +0100):
> 
>> C-h v outline-regexp:
>>
>> outline-regexp is a variable defined in `outline.el'.
>> Its value is
>> ";;;\\(;* [^ 	\n]\\|###autoload\\)\\|("
>> Local in buffer ar-thing-at-point-utils-intern.el; global value is "(\\|[A-Z]"
> 
> Yes, some modes such as emacs-lisp-mode make buffer-local settings of
> outline-regexp, since the value is likely to be very dependent on the
> type of file.
> 
> As it says in the documentation of that variable:
> 
>   The recommended way to set this is with a Local Variables: list
>   in the file it applies to.
> 
> Or use a mode-hook.
> 


Did see that recommendation.
However, from my point of view modes should not overwrite expressingly set customizations.

Local variables definitions set inside the file are nasty.

Anyway, thanks for your care.

Andreas

bug#5627: 23.1.90; outline-regexp ignores customization

[Stefan Monnier]

> edebug displayed: outline-regexp as delivered is used
> after customization still. Also if custom-file was
> loaded from my daily Emacs.

I think the right fix is to make it a defvar rather than a defcustom.
Any objection?


        Stefan

bug#5627: 23.1.90; outline-regexp ignores customization

[Andreas Röhler]

Stefan Monnier wrote:
>> edebug displayed: outline-regexp as delivered is used
>> after customization still. Also if custom-file was
>> loaded from my daily Emacs.
> 
> I think the right fix is to make it a defvar rather than a defcustom.
> Any objection?
> 
> 
>         Stefan
> 
> 
> 
> 
> 

Hi Stefan,

customization of this var is the way adapting it at changing needs.
A defvar seems rather worst.

BTW think it's a very good old bug, probably several people tried to fix this already.
Meanwhile with hide-show is a advanced mode available, which does the same but much better
- not being limited by reg-exp detecting the end.

Think it's ok leaving this bug as it is for now, just not to forget it exist.

Andreas

bug#5627: 23.1.90; outline-regexp ignores customization

[Stefan Monnier]

> customization of this var is the way adapting it at changing needs.
> A defvar seems rather worst.

No, as you have noticed, this variable is major-mode dependent, so
there's no point customizing it with Custom since Custom only knows how
to manipulate default (aka global) settings.

If/when Custom is improved to handle mode-dependent settings, we can
revisit this, but for now it makes no sense to me to provide it as
a defcustom.


        Stefan

bug#5627: 23.1.90; outline-regexp ignores customization

[Andreas Röhler]

Stefan Monnier wrote:
>> customization of this var is the way adapting it at changing needs.
>> A defvar seems rather worst.
> 
> No, as you have noticed, this variable is major-mode dependent, so
> there's no point customizing it with Custom since Custom only knows how
> to manipulate default (aka global) settings.
> 

Probably I ignore something: should't a globally set variable work in a mode also?


> If/when Custom is improved to handle mode-dependent settings, we can
> revisit this, but for now it makes no sense to me to provide it as
> a defcustom.
> 
> 
>         Stefan
> 

A clean solution in my eyes would be to remove the mode-setting - rather retain the global variable here.
As it's name says, its mode-oriented anyway.

Andreas

bug#5627: 23.1.90; outline-regexp ignores customization

[Stefan Monnier]

> A clean solution in my eyes would be to remove the mode-setting -
> rather retain the global variable here.  As it's name says, its
> mode-oriented anyway.

You apparently want something else than outline-minor-mode.
Have you tried allout-mode?


        Stefan