From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#7236: 24.0.50; make-local-hook missing Date: Mon, 18 Oct 2010 21:22:10 -0400 Message-ID: References: <87y69vbyrk.fsf@mail.eng.it> <19644.32383.529459.435414@mail.eng.it> <20101018214207.GB3396@muc.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1287453027 18008 80.91.229.12 (19 Oct 2010 01:50:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 19 Oct 2010 01:50:27 +0000 (UTC) Cc: 7236@debbugs.gnu.org, saint@eng.it To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 19 03:50:25 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P81LL-0003IE-9V for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Oct 2010 03:50:23 +0200 Original-Received: from localhost ([127.0.0.1]:39539 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P81LK-0002QA-ID for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Oct 2010 21:50:22 -0400 Original-Received: from [140.186.70.92] (port=56973 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P81EM-00064P-K8 for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2010 21:45:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P81Dl-0004Wh-92 for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2010 21:42:34 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P81Dl-0004Wd-6B for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2010 21:42:33 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P80r0-0003Gl-Gz; Mon, 18 Oct 2010 21:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2010 01:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7236 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7236-submit@debbugs.gnu.org id=B7236.128745111512560 (code B ref 7236); Tue, 19 Oct 2010 01:19:02 +0000 Original-Received: (at 7236) by debbugs.gnu.org; 19 Oct 2010 01:18:35 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P80qZ-0003GX-0o for submit@debbugs.gnu.org; Mon, 18 Oct 2010 21:18:35 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P80qW-0003GR-ES for 7236@debbugs.gnu.org; Mon, 18 Oct 2010 21:18:32 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjALAJePvExMCpO7/2dsb2JhbACgVXlyw3KFSQSFDI0N X-IronPort-AV: E=Sophos;i="4.57,347,1283745600"; d="scan'208";a="80065930" Original-Received: from 76-10-147-187.dsl.teksavvy.com (HELO pastel.home) ([76.10.147.187]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 18 Oct 2010 21:22:16 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id ABE70A822F; Mon, 18 Oct 2010 21:22:10 -0400 (EDT) In-Reply-To: <20101018214207.GB3396@muc.de> (Alan Mackenzie's message of "Mon, 18 Oct 2010 21:42:07 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 18 Oct 2010 21:19:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40981 Archived-At: >> >>> Start emacs, ask for the documentation for make-local-hook. The >> >>> program signals [No Match]. SM> It's been removed, indeed. It was obsolete since Emacs-21. >> > How could I replace it ? >> You don't need to: calls to make-local-hook have been unnecessary since >> Emacs-21. > Stop being so dismissive, for crying out loud! I'm sorry if I sounded dismissive, but I assure you that it was not my intention. > Whilst what you've said is true, it evades the point. That point is > that there is lots of elisp code (including standalone CC Mode) which > calls the damned function, and now that it has been removed, that code > does not compile. This is inconvenient. Then maybe we shouldn't remove it yet. > I think that m-l-h is only unnecessary when the LOCAL param is set in > some calls to `add-hook'; i.e. for each instance of m-l-h, some hacker > has carefully to work out what the implications are. No: m-l-h is also unnecessary when add-hook is called with a nil LOCAL argument. I know of no case where calling make-local-hook makes a difference in Emacs>=21. > Removing `make-local-hook' is causing bother. It's eradication may be > worth that bother. But please accept that that bother exists. I never said otherwise. This bug-report is the first complaint I hear about it, so it's not obvious at all that this is a big issue. I'll be happy to add a (define-obsolete-function-alias 'make-local-hook 'ignore "21.1") if removing that definition is somewhat problematic. As you know, we're usually pretty conservative when it comes to removing obsolete stuff. Stefan