From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alan Mackenzie <acm@muc.de>
Cc: 7236@debbugs.gnu.org, saint@eng.it
Subject: bug#7236: 24.0.50; make-local-hook missing
Date: Mon, 18 Oct 2010 21:22:10 -0400 [thread overview]
Message-ID: <jwvaambrnkk.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20101018214207.GB3396@muc.de> (Alan Mackenzie's message of "Mon, 18 Oct 2010 21:42:07 +0000")
>> >>> Start emacs, ask for the documentation for make-local-hook. The
>> >>> program signals [No Match].
SM> It's been removed, indeed. It was obsolete since Emacs-21.
>> > How could I replace it ?
>> You don't need to: calls to make-local-hook have been unnecessary since
>> Emacs-21.
> Stop being so dismissive, for crying out loud!
I'm sorry if I sounded dismissive, but I assure you that it was not
my intention.
> Whilst what you've said is true, it evades the point. That point is
> that there is lots of elisp code (including standalone CC Mode) which
> calls the damned function, and now that it has been removed, that code
> does not compile. This is inconvenient.
Then maybe we shouldn't remove it yet.
> I think that m-l-h is only unnecessary when the LOCAL param is set in
> some calls to `add-hook'; i.e. for each instance of m-l-h, some hacker
> has carefully to work out what the implications are.
No: m-l-h is also unnecessary when add-hook is called with a nil LOCAL
argument. I know of no case where calling make-local-hook makes
a difference in Emacs>=21.
> Removing `make-local-hook' is causing bother. It's eradication may be
> worth that bother. But please accept that that bother exists.
I never said otherwise. This bug-report is the first complaint I hear
about it, so it's not obvious at all that this is a big issue.
I'll be happy to add a (define-obsolete-function-alias 'make-local-hook
'ignore "21.1") if removing that definition is somewhat problematic.
As you know, we're usually pretty conservative when it comes to removing
obsolete stuff.
Stefan
next prev parent reply other threads:[~2010-10-19 1:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 10:06 bug#7236: 24.0.50; make-local-hook missing Gian Uberto Lauri
2010-10-18 17:00 ` Stefan Monnier
2010-10-18 17:06 ` saint
2010-10-18 20:14 ` Stefan Monnier
2010-10-18 21:42 ` Alan Mackenzie
2010-10-19 1:22 ` Stefan Monnier [this message]
2010-10-19 2:15 ` Drew Adams
2010-10-19 16:32 ` Stefan Monnier
2010-10-19 17:14 ` Drew Adams
2010-10-19 7:11 ` saint
2010-10-19 16:32 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvaambrnkk.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=7236@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=saint@eng.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.