Re: Sync docs between X, W32, NS

Re: Sync docs between X, W32, NS

[Eli Zaretskii]

> Date: Fri, 29 Oct 2010 04:18:22 -0400
> From: emacs-diffs-request@gnu.org
> 
> revno: 102145
> committer: Glenn Morris <rgm@gnu.org>
> branch nick: trunk
> timestamp: Fri 2010-10-29 00:04:09 -0700
> message:
>   Sync docs of some X, W32, NS C functions.
>   
>   * src/nsfns.m (Fx-display-save-under, Fx-open-connection)
>   (Fxw-color-defined-p, Fxw-display-color-p, Fx-show-tip):
>   * src/w32fns.c (Fxw_color_defined_p, Fx_open_connection):
>   * src/xfns.c (Fxw_color_defined_p, Fx_open_connection):
>   Sync docs between X, W32, NS.
> modified:
>   src/ChangeLog
>   src/nsfns.m
>   src/w32fns.c
>   src/xfns.c
> -------------- next part --------------
> === modified file 'src/ChangeLog'
> --- a/src/ChangeLog	2010-10-29 03:29:29 +0000
> +++ b/src/ChangeLog	2010-10-29 07:04:09 +0000
> @@ -1,5 +1,11 @@
>  2010-10-29  Glenn Morris  <rgm@gnu.org>
>  
> +	* nsfns.m (Fx-display-save-under, Fx-open-connection)
> +	(Fxw-color-defined-p, Fxw-display-color-p, Fx-show-tip):
> +	* w32fns.c (Fxw_color_defined_p, Fx_open_connection):
> +	* xfns.c (Fxw_color_defined_p, Fx_open_connection):
> +	Sync docs between X, W32, NS.
> +

I wonder if it wouldn't be better to have only one implementation of
these functions, with most of their bodies in separate functions that
live in platform-specific files.  Then the doc string would be in only
one place, which I think will deliver us from the need to go through
this pain in the future.

Re: Sync docs between X, W32, NS

[Glenn Morris]

Eli Zaretskii wrote:

> I wonder if it wouldn't be better to have only one implementation of
> these functions, with most of their bodies in separate functions that
> live in platform-specific files.  Then the doc string would be in only
> one place, which I think will deliver us from the need to go through
> this pain in the future.

Absolutely something like that would be better. (The doc-strings will
still need to be unified, so the current changes are a small step in
the right direction.)

Re: Sync docs between X, W32, NS

[Stefan Monnier]

> I wonder if it wouldn't be better to have only one implementation of

I don't wonder.  I know it to be the case (and have said so in this
list a few times already).


        Stefan