From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8415: 23.3.50; Extensible Emacs Registers Date: Sat, 25 Jun 2011 09:19:50 -0400 Message-ID: References: <4D9A45CD.4030808@gmail.com> <4D9A7537.5030005@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1309008089 16837 80.91.229.12 (25 Jun 2011 13:21:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 25 Jun 2011 13:21:29 +0000 (UTC) Cc: 8415@debbugs.gnu.org To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 25 15:21:25 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QaSnc-0002rF-2H for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Jun 2011 15:21:24 +0200 Original-Received: from localhost ([::1]:35155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaSnW-0006So-Gm for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Jun 2011 09:21:18 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:51057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaSnH-0006Sg-UY for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2011 09:21:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QaSnG-0004ip-Rz for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2011 09:21:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaSnG-0004ik-PB for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2011 09:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QaSnG-0001oY-1m; Sat, 25 Jun 2011 09:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Jun 2011 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8415 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13090080076909 (code B ref -1); Sat, 25 Jun 2011 13:21:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Jun 2011 13:20:07 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaSmM-0001nO-9k for submit@debbugs.gnu.org; Sat, 25 Jun 2011 09:20:06 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaSmK-0001ms-JB for submit@debbugs.gnu.org; Sat, 25 Jun 2011 09:20:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QaSmE-0004bT-En for submit@debbugs.gnu.org; Sat, 25 Jun 2011 09:19:59 -0400 Original-Received: from lists.gnu.org ([140.186.70.17]:50073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaSmE-0004bP-DP for submit@debbugs.gnu.org; Sat, 25 Jun 2011 09:19:58 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:50957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaSmD-0006NG-8D for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2011 09:19:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QaSmC-0004b3-9w for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2011 09:19:57 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:48911 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaSmC-0004ay-6L for bug-gnu-emacs@gnu.org; Sat, 25 Jun 2011 09:19:56 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAN3dBU5MCqDH/2dsb2JhbABTp0d4iHTBV4YwBJ4RhCk X-IronPort-AV: E=Sophos;i="4.65,424,1304308800"; d="scan'208";a="117113299" Original-Received: from 76-10-160-199.dsl.teksavvy.com (HELO pastel.home) ([76.10.160.199]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 25 Jun 2011 09:19:51 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 0098958FD6; Sat, 25 Jun 2011 09:19:50 -0400 (EDT) In-Reply-To: (Leo's message of "Thu, 23 Jun 2011 16:11:27 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 25 Jun 2011 09:21:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47454 Archived-At: > Is this patch OK? Looks OK, yes. > + (jump-func (funcall jump-func (registerv-data val))) But I'd pass `val' directly, so the function can use extra fields in values that inherit from registerv. You could drop the `data' field as well, at that point. This just makes it more OO, and maybe experience would show that it actually makes things worse (just adds unused extra flexibility), so I'll let you judge. Either way is OK with me. Stefan