From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo <sdl.web@gmail.com>
Cc: 8415@debbugs.gnu.org
Subject: bug#8415: 23.3.50; Extensible Emacs Registers
Date: Sat, 25 Jun 2011 09:19:50 -0400 [thread overview]
Message-ID: <jwvaad6gihd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m1wrgdezm8.fsf@gmail.com> (Leo's message of "Thu, 23 Jun 2011 16:11:27 +0800")
> Is this patch OK?
Looks OK, yes.
> + (jump-func (funcall jump-func (registerv-data val)))
But I'd pass `val' directly, so the function can use extra fields in
values that inherit from registerv. You could drop the `data' field as
well, at that point.
This just makes it more OO, and maybe experience would show that it
actually makes things worse (just adds unused extra flexibility), so
I'll let you judge. Either way is OK with me.
Stefan
next prev parent reply other threads:[~2011-06-25 13:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 12:29 bug#8415: 23.3.50; Extensible Emacs Registers Leo
2011-04-03 17:21 ` Daniel Colascione
2011-04-04 1:29 ` Leo
2011-04-04 14:29 ` Stefan Monnier
2011-04-04 17:37 ` Leo
2011-04-04 22:19 ` Stefan Monnier
2011-04-04 22:27 ` Daniel Colascione
2011-04-05 1:41 ` Stefan Monnier
2011-04-05 1:49 ` Daniel Colascione
2011-04-05 3:07 ` Stefan Monnier
2011-04-05 5:42 ` Leo
2011-04-05 13:50 ` Stefan Monnier
2011-04-06 5:00 ` Leo
2011-04-06 15:38 ` Stefan Monnier
2011-04-07 3:13 ` Leo
2011-04-09 1:25 ` Stefan Monnier
2011-06-23 8:11 ` Leo
2011-06-25 13:19 ` Stefan Monnier [this message]
2011-06-26 6:42 ` Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvaad6gihd.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=8415@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.