From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Tom Tromey <tromey@redhat.com>
Cc: Mohamed Ben-Ahssene <benahssm@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Inefficiency in Bgotoifnil byte-code instruction
Date: Tue, 03 Jul 2012 19:02:38 -0400 [thread overview]
Message-ID: <jwva9zg4fim.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87ipe4vjy1.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue, 03 Jul 2012 11:22:14 -0600")
> I took the "value" approach because the bytecode values are fixed, and I
> thought it was safer to be explicit about them.
> The backslashes are just needed because I made one big #define.
Yes, as I said, I think it's OK. Maybe better would be if the threaded
version actually checked that the `value' is correct (i.e. is one more
than the previous one) rather than just ignore that argument.
> Another approach (used in gcc, gdb, etc) is to put the opcode defines
> into a ".def" file and then include it in multiple places.
I'm not sure it's better, since, as you say, the values are fixed by
external factors.
Feel free to install,
Stefan
next prev parent reply other threads:[~2012-07-03 23:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 3:01 Inefficiency in Bgotoifnil byte-code instruction John Wiegley
2012-06-28 4:38 ` Stefan Monnier
2012-06-29 16:39 ` Tom Tromey
2012-06-30 4:07 ` Stefan Monnier
2012-07-02 19:17 ` Tom Tromey
2012-07-03 13:19 ` Stefan Monnier
2012-07-03 14:45 ` Tom Tromey
2012-07-03 16:58 ` Stefan Monnier
2012-07-03 17:22 ` Tom Tromey
2012-07-03 17:53 ` Aurélien Aptel
2012-07-03 19:24 ` Tom Tromey
2012-07-03 23:02 ` Stefan Monnier [this message]
2012-07-06 20:22 ` Tom Tromey
2012-07-06 21:39 ` Stefan Monnier
2012-07-09 19:12 ` Tom Tromey
2012-07-10 10:31 ` Stefan Monnier
2012-07-03 19:52 ` John Wiegley
2012-07-06 20:27 ` Tom Tromey
2012-07-02 3:51 ` John Wiegley
2012-07-02 14:08 ` Tom Tromey
2012-06-28 4:41 ` Stefan Monnier
2012-06-28 13:07 ` Richard Stallman
2012-06-28 21:24 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva9zg4fim.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=benahssm@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.