From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r110342: Count overruns when profiling; change units to ns. Date: Tue, 02 Oct 2012 09:20:51 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1349184094 25809 80.91.229.3 (2 Oct 2012 13:21:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 2 Oct 2012 13:21:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 02 15:21:40 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TJ2PT-0006Kr-Ca for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2012 15:21:15 +0200 Original-Received: from localhost ([::1]:32869 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ2PN-0005Ou-IF for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2012 09:21:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ2PD-0005Mf-6S for emacs-devel@gnu.org; Tue, 02 Oct 2012 09:21:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJ2P7-0006rM-B9 for emacs-devel@gnu.org; Tue, 02 Oct 2012 09:20:59 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:14066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ2P7-0006rI-6h for emacs-devel@gnu.org; Tue, 02 Oct 2012 09:20:53 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxLT4/2dsb2JhbABEDrQDgQiCFgEFViMQCzQSFBgNJIghqQyQfZBEA6MzgViCMFU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="200452155" Original-Received: from 69-196-180-248.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.248]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Oct 2012 09:20:52 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 40A18594CC; Tue, 2 Oct 2012 09:20:51 -0400 (EDT) In-Reply-To: (Paul Eggert's message of "Mon, 01 Oct 2012 23:30:40 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153907 Archived-At: > (profiler-report-render-calltree-1): Call them "CPU samples", > not "Time (ms)", since they are not milliseconds now (and > never really were). They were (or close enough) since each sample was weighted according to current_sampling_interval. We can't preserve this weighting while switching to nanoseconds, since that would bump quickly into wrap-around country on 32bit hosts. As you now don't preserve the weighting, we have the new problem that starting/stopping/starting/stopping won't count correctly if profiler-sampling-interval is modified between the two profiler-start. Stefan