From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r110342: Count overruns when profiling; change units to ns.
Date: Tue, 02 Oct 2012 09:20:51 -0400 [thread overview]
Message-ID: <jwva9w5j9qf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1TIwjJ-0005wv-J8@vcs.savannah.gnu.org> (Paul Eggert's message of "Mon, 01 Oct 2012 23:30:40 -0700")
> (profiler-report-render-calltree-1): Call them "CPU samples",
> not "Time (ms)", since they are not milliseconds now (and
> never really were).
They were (or close enough) since each sample was weighted according to
current_sampling_interval.
We can't preserve this weighting while switching to nanoseconds, since
that would bump quickly into wrap-around country on 32bit hosts.
As you now don't preserve the weighting, we have the new problem that
starting/stopping/starting/stopping won't count correctly if
profiler-sampling-interval is modified between the two profiler-start.
Stefan
next parent reply other threads:[~2012-10-02 13:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1TIwjJ-0005wv-J8@vcs.savannah.gnu.org>
2012-10-02 13:20 ` Stefan Monnier [this message]
2012-10-02 16:37 ` [Emacs-diffs] /srv/bzr/emacs/trunk r110342: Count overruns when profiling; change units to ns Paul Eggert
2012-10-02 17:03 ` Eli Zaretskii
2012-10-02 20:52 ` Paul Eggert
2012-10-02 21:17 ` Eli Zaretskii
2012-10-03 5:00 ` Paul Eggert
2012-10-03 17:18 ` Eli Zaretskii
2012-10-03 17:29 ` Paul Eggert
2012-10-03 17:55 ` Eli Zaretskii
2012-10-03 2:05 ` Stefan Monnier
2012-10-03 5:03 ` Paul Eggert
2012-10-03 12:48 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva9w5j9qf.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.