From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: package.el changes before the feature freeze Date: Mon, 08 Oct 2012 15:50:48 -0400 Message-ID: References: <87ipau51jh.fsf@gnu.org> <87626qk5xo.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1349725861 8699 80.91.229.3 (8 Oct 2012 19:51:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 8 Oct 2012 19:51:01 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Daniel Hackney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 08 21:51:06 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TLJLz-0007a1-3S for ged-emacs-devel@m.gmane.org; Mon, 08 Oct 2012 21:51:03 +0200 Original-Received: from localhost ([::1]:51211 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLJLt-0006b6-3i for ged-emacs-devel@m.gmane.org; Mon, 08 Oct 2012 15:50:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:32820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLJLq-0006an-J0 for emacs-devel@gnu.org; Mon, 08 Oct 2012 15:50:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLJLo-0005F7-3W for emacs-devel@gnu.org; Mon, 08 Oct 2012 15:50:54 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:45398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLJLm-0005EB-IW; Mon, 08 Oct 2012 15:50:50 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxLQG/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLDiYSFBgNJIgcBboJkEQDozOBWIMF X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="200876660" Original-Received: from 69-196-180-6.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.6]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 08 Oct 2012 15:50:48 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 4BC3C594D1; Mon, 8 Oct 2012 15:50:48 -0400 (EDT) In-Reply-To: (Daniel Hackney's message of "Mon, 8 Oct 2012 15:16:36 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154246 Archived-At: > The CL info pages refer to them as slots, so that's what I figured I'd > use. There could be a better name for a package defstruct, but "field" > "property" and "attribute" are overdone :) Sure, use whatever suits you. > I agree that the slot name could definitely be improved. `name' does > imply a string to me, but I think that it is good for the "primary key" > of the alists to be a symbol. Something like `canonical-name' perhaps? > `id' maybe? I'm not terribly attached to any particular slot name. `name' is no worse than the others, so just use that. > This was intended to be related to `define-package'; it turns the > `define-package' call into a `package-desc' struct. I understand the motivation, but the use of a "package-" prefix is more important, I think. > I haven't looked at lexical binding in earnest. Should I reference > the non-prefixed form in the body of `define-package'? The symbols prefixed by "_" are not treated specially by the compiler/evaluator. The use of _ only affects the warnings you might get (where a `_foo' that is used or a `foo' that is not used will signal a warning) and the way things are displayed in *Help* (where the underscore is stripped, since whether or not an argument is used is an implementation detail). Stefan