From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: Diff could also show the changes within lines Date: Mon, 19 Nov 2012 09:48:46 -0500 Organization: A noiseless patient Spider Message-ID: References: <87txu9arc8.fsf@gmail.com> <80d2zlvnos.fsf@somewhere.org> <80vcd8l0h4.fsf@somewhere.org> <80zk2j3kkf.fsf@somewhere.org> <80obizp4fv.fsf@somewhere.org> <808va3p0ia.fsf@somewhere.org> <80d2zej3kd.fsf@somewhere.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1353336629 9463 80.91.229.3 (19 Nov 2012 14:50:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 Nov 2012 14:50:29 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Mon Nov 19 15:50:35 2012 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TaSgA-0001ts-MX for geh-help-gnu-emacs@m.gmane.org; Mon, 19 Nov 2012 15:50:30 +0100 Original-Received: from localhost ([::1]:32915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaSfz-0007Mb-Ph for geh-help-gnu-emacs@m.gmane.org; Mon, 19 Nov 2012 09:50:19 -0500 Original-Path: usenet.stanford.edu!goblin1!goblin.stu.neva.ru!eternal-september.org!feeder.eternal-september.org!mx04.eternal-september.org!.POSTED!not-for-mail Original-Newsgroups: gnu.emacs.help Original-Lines: 27 Injection-Info: mx04.eternal-september.org; posting-host="9b718dca22ff4598baab0f6e08a1d03d"; logging-data="9904"; mail-complaints-to="abuse@eternal-september.org"; posting-account="U2FsdGVkX181+yyHzEzT1VrBR6NGR4fc" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:3M4D4iDWNeCmzkiUMnfgDcdVEnE= sha1:ZSRQT4aSQmp5Z9Pb7kHmfz3RzEQ= Original-Xref: usenet.stanford.edu gnu.emacs.help:195461 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:87784 Archived-At: >> If you let-bind diff-auto-refine-mode to nil in the above code, not only >> you'll be able to test it on Emacs-24.1 (and earlier), but you'll avoid >> refining the hunks redundantly when diff-hunk-next does it. > Good suggestion. Thank you. > What I did not get in the new diff-mode implementation is why it > uses run-at-time instead of run-with-idle-timer? > run-at-time is for specifying a timer which runs at a specific time > while run-with-idle-timer runs it when emacs becomes idle. Isn't > using run-with-idle-timer is more appropriate (makes the code clearer) > in this case? run-at-time timers don't run while Elisp is running either, they only run when Elisp is being interrupted (e.g. during redisplay, or while running process filters). So the difference is pretty slim (more specifically, there's only a difference in the case where diff-hunk-next is run from code which later calls something like sit-for or redisplay). > And why the code uses 0.0 instead of just 0? I can't remember. > Is there a difference? No, no difference. Stefan