From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f) Date: Fri, 28 Jun 2013 23:24:50 -0400 Message-ID: References: <87ppv550s6.fsf@web.de> <309ce668-1d40-4865-b796-d6828f65a8d4@default> <49fae9c3-c59c-4b08-84f0-24dc9935b345@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1372476369 24353 80.91.229.3 (29 Jun 2013 03:26:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Jun 2013 03:26:09 +0000 (UTC) Cc: Michael Heerdegen , 14734@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 29 05:26:07 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uslna-000431-VL for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Jun 2013 05:26:07 +0200 Original-Received: from localhost ([::1]:45171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uslna-0003kJ-Iw for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jun 2013 23:26:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UslnX-0003kB-HM for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2013 23:26:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UslnW-0003Cl-HF for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2013 23:26:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UslnW-0003Cf-Dt for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2013 23:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UslnW-0000a5-3k for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2013 23:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jun 2013 03:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 14734-submit@debbugs.gnu.org id=B14734.13724763032162 (code B ref 14734); Sat, 29 Jun 2013 03:26:02 +0000 Original-Received: (at 14734) by debbugs.gnu.org; 29 Jun 2013 03:25:03 +0000 Original-Received: from localhost ([127.0.0.1]:47589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UslmY-0000Yd-1I for submit@debbugs.gnu.org; Fri, 28 Jun 2013 23:25:02 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:20630) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UslmS-0000YD-Vx for 14734@debbugs.gnu.org; Fri, 28 Jun 2013 23:24:59 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="17430556" Original-Received: from 76-10-154-64.dsl.teksavvy.com (HELO pastel.home) ([76.10.154.64]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 28 Jun 2013 23:24:45 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 96BDC67951; Fri, 28 Jun 2013 23:24:50 -0400 (EDT) In-Reply-To: <49fae9c3-c59c-4b08-84f0-24dc9935b345@default> (Drew Adams's message of "Fri, 28 Jun 2013 19:28:35 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75705 Archived-At: > An argument was made that the REimplementation of something that > worked well was done (was necessary?) to allow for backward > compatibility. I was speaking to that argument. There has been no reimplementation (that would have been a waste of time, since it's a package planned to become obsolete). There's only been some adjustments to make it so that the two advice packages don't step on each other's feet. More specifically, the old advice.el was made to work on top of the new nadvice.el (the total size of the the new advice.el and nadvice.el is about the same as the old advice.el). The old advice.el could be reimplemented to use nadvice more directly (e.g. so that each defadvice turns into a single advice-add, rather than bundling all defadvice into a single advice-add), which would solve some of your complaints, but it's a lot of work and would probably break more backward compatibility because it'd be difficult to preserve some details of advice.el's semantics. Stefan