bug#16807: 24.3.50; changes in advice.el break multi-term.el

bug#16807: 24.3.50; changes in advice.el break multi-term.el

[henry atting]

 In GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 3.8.6)
 of 2014-02-08 on bye

I know multi-term.el is not part of emacs and, what is more, isn't
developed anymore as far as I can see. So take it much more as a brief
remark than as a bug report.

Following function and macro where removed from advice.el:

(defmacro ad-macro-p (definition)
  ;;"non-nil if DEFINITION is a macro."
  (` (eq (car-safe (, definition)) 'macro)))


(defun ad-advised-definition-p (definition)
  ;;"non-nil if DEFINITION was generated from advice information."
  (if (or (ad-lambda-p definition)
	  (ad-macro-p definition)
	  (ad-compiled-p definition))
      (let ((docstring (ad-docstring definition)))
	(and (stringp docstring)
	     (string-match
	      ad-advised-definition-docstring-regexp docstring)))))

But multi-term depends on it.

Putting these lines somewhere at the beginning of ~/.emacs works for me
as a workaround.

bug#16807: 24.3.50; changes in advice.el break multi-term.el

[Glenn Morris]

OK, thanks for the info.
I don't think those definitions are coming back, so from the Emacs side
there isn't really anything to do here. It seems pretty odd that
multi-term would be using those, I doubt if it really needed to do so
(but I've never looked at it).

bug#16807: 24.3.50; changes in advice.el break multi-term.el

[Stefan Monnier]

> (defmacro ad-macro-p (definition)

multi-term.el can use the new `macrop' instead.  But I don't see any use
of ad-macro-p in
https://github.com/milkypostman/multi-term/blob/master/multi-term.el

> (defun ad-advised-definition-p (definition)

multi-term.el doesn't really need this anyway, it seems.  I.e. you can
just replace it with (defun ad-advised-definition-p (def) t))

Both of these were too internal to be worth providing (even as obsolete
definitions).


        Stefan