From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.bugs Subject: bug#16993: advice-add hides docstring Date: Wed, 19 Mar 2014 14:29:19 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1395253817 31116 80.91.229.3 (19 Mar 2014 18:30:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Mar 2014 18:30:17 +0000 (UTC) Cc: 16993@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 19 19:30:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WQLFw-0005SZ-9j for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Mar 2014 19:30:24 +0100 Original-Received: from localhost ([::1]:43176 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQLFv-0004Jk-T4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Mar 2014 14:30:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQLFj-0003qS-Vw for bug-gnu-emacs@gnu.org; Wed, 19 Mar 2014 14:30:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQLFc-0002mH-Mc for bug-gnu-emacs@gnu.org; Wed, 19 Mar 2014 14:30:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQLFc-0002l2-K9 for bug-gnu-emacs@gnu.org; Wed, 19 Mar 2014 14:30:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WQLFb-0004Uh-Ca for bug-gnu-emacs@gnu.org; Wed, 19 Mar 2014 14:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Mar 2014 18:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.139525376317186 (code B ref 16993); Wed, 19 Mar 2014 18:30:03 +0000 Original-Received: (at 16993) by debbugs.gnu.org; 19 Mar 2014 18:29:23 +0000 Original-Received: from localhost ([127.0.0.1]:41529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQLEx-0004T8-4C for submit@debbugs.gnu.org; Wed, 19 Mar 2014 14:29:23 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:9620) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQLEu-0004Sz-Om for 16993@debbugs.gnu.org; Wed, 19 Mar 2014 14:29:21 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+KKg/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDjhiWYoFegxM X-IPAS-Result: Av4EABK/CFHO+KKg/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDjhiWYoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="52636318" Original-Received: from 206-248-162-160.dsl.teksavvy.com (HELO pastel.home) ([206.248.162.160]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 19 Mar 2014 14:29:20 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id C5A3C60123; Wed, 19 Mar 2014 14:29:19 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Wed, 12 Mar 2014 05:38:03 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86986 Archived-At: > Some advice-add'ed functions lose their docstring. Current examples > from "emacs -Q" include `insert-directory', `rename-buffer' and > `create-file-buffer'. That's an incompatibility with Snarf-documentation: Snarf-documentation scans the DOC file, finds the doc of rename-buffer, and tries to stick the corresponding DOC offset in rename-buffer's "docstring slot". This should set the "docstring slot" of the #, but instead (symbol-function 'rename-buffer) returns an `advice--p' object, so Snarf-documentation tries to set the docstring slot of that object (which fails because the vector doesn't have a slot for it, but even if it succeeded it wouldn't be what we want). We can either fix it by teaching Snarf-documentation about advised function (yuck!) or by not advising functions that are documented in DOC. IOW the right fix is to get rid of those advices in uniquify.el. Stefan