* bug#17807: 24.4.50; hif-string-to-number convert a hex(or any non-decial) integer as float
@ 2014-06-19 6:26 William Xu
2014-06-19 21:09 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: William Xu @ 2014-06-19 6:26 UTC (permalink / raw
To: 17807
[-- Attachment #1.1: Type: text/plain, Size: 1438 bytes --]
(hif-string-to-number "0F" 16)
=> 15.0
It would fail hif-logand, like the one below, caught in cedet.
Is it really necessary to support non-decial floats? When is something
like "0xff.e9" useful?
Anyway, how about attached fix?
---------------------------------8<-------------------------------------
Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p 15.0)
logand(0 15.0)
hif-logand(0 15.0)
(hif-notequal (hif-logand (hif-lookup (quote SPURIOUS_APIC_VECTOR)) 15.0)
15.0)
eval((hif-notequal (hif-logand (hif-lookup (quote SPURIOUS_APIC_VECTOR))
15.0) 15.0))
semantic-c-do-lex-if()
semantic-c-lexer(1 4938 nil nil)
semantic-lex(1 4938 nil)
semantic-parse-region-default(1 4938 nil nil nil)
semantic-parse-region-c-mode(1 4938 nil nil nil)
semantic-parse-region(1 4938)
semantic-fetch-tags()
byte-code("\212\212\300 \210*\301\207" [semantic-fetch-tags nil] 1)
semantic-idle-scheduler-refresh-tags()
(and (semantic-idle-scheduler-enabled-p)
(semantic-idle-scheduler-refresh-tags))
...
---------------------------------8<-------------------------------------
In GNU Emacs 24.4.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2)
of 2014-06-10 on linux-xwl
Windowing system distributor `The X.Org Foundation', version 11.0.11501000
System Description: Debian GNU/Linux unstable (sid)
Configured using:
`configure --with-x-toolkit=gtk3'
--
William
http://xwl.appspot.com
[-- Attachment #1.2: Type: text/html, Size: 1723 bytes --]
[-- Attachment #2: 0001-Convert-non-decimal-integer-string-still-as-an-integ.patch --]
[-- Type: text/x-patch, Size: 1283 bytes --]
From 83f61b25fe896112420e4b9d00b7db8c8b6d8bcf Mon Sep 17 00:00:00 2001
From: William Xu <william.1.xu@microsoft.com>
Date: Thu, 19 Jun 2014 14:18:36 +0800
Subject: [PATCH] Convert non-decimal integer string still as an integer.
(hif-string-to-number): e.g., Change (hif-string-to-number "0F" 16) to
return `15' instead of `15.0'.
---
lisp/progmodes/hideif.el | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/lisp/progmodes/hideif.el b/lisp/progmodes/hideif.el
index bcb4659..ee144df 100644
--- a/lisp/progmodes/hideif.el
+++ b/lisp/progmodes/hideif.el
@@ -412,9 +412,13 @@ that form should be displayed.")
(if (or (not base) (= base 10))
(string-to-number string base)
(let* ((parts (split-string string "\\." t "[ \t]+"))
- (frac (cadr parts))
- (quot (expt (* base 1.0) (length frac))))
- (/ (string-to-number (concat (car parts) frac) base) quot))))
+ (frac (cadr parts))
+ (quot (expt (* base 1.0) (length frac)))
+ (num (/ (string-to-number (concat (car parts) frac) base)
+ quot)))
+ (if (= num (truncate num))
+ (truncate num)
+ num))))
(defun hif-tokenize (start end)
"Separate string between START and END into a list of tokens."
--
2.0.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#17807: 24.4.50; hif-string-to-number convert a hex(or any non-decial) integer as float
2014-06-19 6:26 bug#17807: 24.4.50; hif-string-to-number convert a hex(or any non-decial) integer as float William Xu
@ 2014-06-19 21:09 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2014-06-19 21:09 UTC (permalink / raw
To: William Xu; +Cc: 17807-done
> (hif-string-to-number "0F" 16)
> => 15.0
[...]
> Anyway, how about attached fix?
Thanks, installed into trunk,
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-19 21:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-19 6:26 bug#17807: 24.4.50; hif-string-to-number convert a hex(or any non-decial) integer as float William Xu
2014-06-19 21:09 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.