From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#19363: Acknowledgement (24.4.1; Notifications can make ERC unusable) Date: Sun, 04 Jan 2015 20:54:54 -0500 Message-ID: References: <87r3w4njp1.fsf@secretsauce.net> <87egrgmd29.fsf@secretsauce.net> <87bnmkmbx8.fsf@secretsauce.net> <878uhnn3ub.fsf@secretsauce.net> <87mw5ykyl8.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1420422922 4705 80.91.229.3 (5 Jan 2015 01:55:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Jan 2015 01:55:22 +0000 (UTC) Cc: 19363@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 05 02:55:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y7wsx-0000KB-S2 for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jan 2015 02:55:12 +0100 Original-Received: from localhost ([::1]:58728 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7wsx-0003uR-AI for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Jan 2015 20:55:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7wss-0003pX-UH for bug-gnu-emacs@gnu.org; Sun, 04 Jan 2015 20:55:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y7wsp-0004r8-Hu for bug-gnu-emacs@gnu.org; Sun, 04 Jan 2015 20:55:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7wsp-0004qj-FO for bug-gnu-emacs@gnu.org; Sun, 04 Jan 2015 20:55:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Y7wso-0008Du-TR for bug-gnu-emacs@gnu.org; Sun, 04 Jan 2015 20:55:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jan 2015 01:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19363 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19363-submit@debbugs.gnu.org id=B19363.142042290131595 (code B ref 19363); Mon, 05 Jan 2015 01:55:02 +0000 Original-Received: (at 19363) by debbugs.gnu.org; 5 Jan 2015 01:55:01 +0000 Original-Received: from localhost ([127.0.0.1]:36813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7wsm-0008DT-MZ for submit@debbugs.gnu.org; Sun, 04 Jan 2015 20:55:00 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:42551) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7wsi-0008D0-8y for 19363@debbugs.gnu.org; Sun, 04 Jan 2015 20:54:57 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjwPAOwQflRFpY0B/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViECBQsLNBIUGA0kiEoJ1lkBAQEBBgEBAQEekG8HhEgFiwGSMY9zggqBeIQZIYJ3AQEB X-IPAS-Result: AjwPAOwQflRFpY0B/2dsb2JhbABbgweDYIVaxR0EAgKBJBcBAQEBAQF8hAMBAQMBViECBQsLNBIUGA0kiEoJ1lkBAQEBBgEBAQEekG8HhEgFiwGSMY9zggqBeIQZIYJ3AQEB X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="106578887" Original-Received: from 69-165-141-1.dsl.teksavvy.com (HELO pastel.home) ([69.165.141.1]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 Jan 2015 20:54:54 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 63DD52527; Sun, 4 Jan 2015 20:54:54 -0500 (EST) In-Reply-To: <87mw5ykyl8.fsf@secretsauce.net> (Dima Kogan's message of "Sun, 04 Jan 2015 13:26:15 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98017 Archived-At: > Hi. I suspect that hard-coding this would be a very big and unwelcome > change in this case because there's some indirection here. Each ERC > "response handler" has a hook such as this. The (defvar ...) > (add-to-list ...) happens in the macro that defines a response handler: > define-erc-response-handler, and the hooks are invoked in a general way > for all server responses in erc-handle-parsed-server-response. > So the bug I was seeing was due specifically to missing PRIVMSG response > handlers, but the patch fixes all response handlers generically. Right. So maybe it can be fixed "better" via a more significant restructuring, but that's still to be shown. Feel free to install your patch, thank you, Stefan