From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: #2 [Was: Re: Function attributes for make-docfile] Date: Thu, 15 Jan 2015 00:33:34 -0500 Message-ID: References: <54B348E8.7080203@yandex.ru> <54B3604E.9020304@cs.ucla.edu> <54B3BDE3.8030602@yandex.ru> <54B4C971.7010209@cs.ucla.edu> <54B5A991.8010509@cs.ucla.edu> <54B6C71A.1040101@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1421300032 14764 80.91.229.3 (15 Jan 2015 05:33:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Jan 2015 05:33:52 +0000 (UTC) Cc: Dmitry Antipov , Emacs development discussions To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 15 06:33:46 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YBd3v-0003us-D1 for ged-emacs-devel@m.gmane.org; Thu, 15 Jan 2015 06:33:43 +0100 Original-Received: from localhost ([::1]:49155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBd3u-0003UE-Nf for ged-emacs-devel@m.gmane.org; Thu, 15 Jan 2015 00:33:42 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBd3s-0003U9-6d for emacs-devel@gnu.org; Thu, 15 Jan 2015 00:33:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBd3o-0003CB-NZ for emacs-devel@gnu.org; Thu, 15 Jan 2015 00:33:40 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:31840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBd3o-0003C5-K2 for emacs-devel@gnu.org; Thu, 15 Jan 2015 00:33:36 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjwPAOwQflS4rwoL/2dsb2JhbABbDoJ5g2CFWsUdBAICgSQXAQEBAQEBfIQDAQEDAVYjBQsLNBIUGA0kiEoJ1lkBAQEHAQEBAR6QbweESAWLAaQugXiDO14hgncBAQE X-IPAS-Result: AjwPAOwQflS4rwoL/2dsb2JhbABbDoJ5g2CFWsUdBAICgSQXAQEBAQEBfIQDAQEDAVYjBQsLNBIUGA0kiEoJ1lkBAQEHAQEBAR6QbweESAWLAaQugXiDO14hgncBAQE X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="107862081" Original-Received: from 184-175-10-11.dsl.teksavvy.com (HELO ceviche.home) ([184.175.10.11]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 15 Jan 2015 00:33:34 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id A1259660FB; Thu, 15 Jan 2015 00:33:34 -0500 (EST) In-Reply-To: <54B6C71A.1040101@cs.ucla.edu> (Paul Eggert's message of "Wed, 14 Jan 2015 11:44:26 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181277 Archived-At: > Assuming --enable-gcc-warnings, it's a combination of things. First, > gcc -Wsuggest-attribute=const complains if it can deduce that an extern > function is const but the function wasn't declared const. Easy, then: either you live with this warning, or you don't enable -Wsuggest-attribute=const. Just silencing such a warning is no justification for this kind of hideous code. Using -Wsuggest-attribute=const every once in a while to see what could be improved is probably a good idea, but we shouldn't blindly follow its suggestions. Stefan