From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Dmitry Antipov <dmantipov@yandex.ru>,
Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: #2 [Was: Re: Function attributes for make-docfile]
Date: Thu, 15 Jan 2015 00:33:34 -0500 [thread overview]
Message-ID: <jwva91ky5ky.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <54B6C71A.1040101@cs.ucla.edu> (Paul Eggert's message of "Wed, 14 Jan 2015 11:44:26 -0800")
> Assuming --enable-gcc-warnings, it's a combination of things. First,
> gcc -Wsuggest-attribute=const complains if it can deduce that an extern
> function is const but the function wasn't declared const.
Easy, then: either you live with this warning, or you don't
enable -Wsuggest-attribute=const.
Just silencing such a warning is no justification for this kind of
hideous code.
Using -Wsuggest-attribute=const every once in a while to see what could
be improved is probably a good idea, but we shouldn't blindly follow its
suggestions.
Stefan
next prev parent reply other threads:[~2015-01-15 5:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 4:09 Function attributes for make-docfile Dmitry Antipov
2015-01-12 5:33 ` Stefan Monnier
2015-01-12 5:49 ` Paul Eggert
2015-01-12 12:28 ` #2 [Was: Re: Function attributes for make-docfile] Dmitry Antipov
2015-01-13 7:29 ` Paul Eggert
2015-01-13 10:21 ` Dmitry Antipov
2015-01-13 17:43 ` Paul Eggert
2015-01-13 19:45 ` Stefan Monnier
2015-01-13 23:26 ` Paul Eggert
2015-01-14 17:49 ` Stefan Monnier
2015-01-14 19:44 ` Paul Eggert
2015-01-15 3:27 ` Dmitry Antipov
2015-01-15 3:54 ` Dmitry Antipov
2015-01-15 5:33 ` Stefan Monnier [this message]
2015-01-16 4:50 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva91ky5ky.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dmantipov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.