all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Juri Linkov <juri@linkov.net>
Cc: Bastien <bzg@gnu.org>, 19829@debbugs.gnu.org
Subject: bug#19829: 25.0.50; Design of commands operating on rectangular regions
Date: Tue, 07 Jul 2015 08:20:28 -0400	[thread overview]
Message-ID: <jwva8v9xwar.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <877fqi89ii.fsf@mail.linkov.net> (Juri Linkov's message of "Fri,  03 Jul 2015 01:40:37 +0300")

>> IOW, either your REGION arg uses a standard format (e.g. a list of
>> (START . END) boundaries), or it should be just a constant saying "use
>> things like region-extract-function ".
> Or better to check the value returned by region-extract-function
> in `interactive' with:
>   (defun region-nonstandard ()
>     (> (length (funcall region-extract-function 'positions)) 1))
> like the patch below does.

The idea of a constant saying "use the region" is also to distinguish it
from the case where the function is called non-interactively with
boundaries which aren't necessarily related to the current region.

>   region-noncontiguous

I like this name (tho with a final "-p") since it says precisely what
it means.

> Then we could replace in `interactive' calls `region-beginning'
> with `region-beginning-nonstandard' defined as:

No, I'd just replace it with the special constant that says "use things
like region-extract-function".  This constant could be just t or `region'.

> But I'm still not sure whether ugly is nicer than hideous,
> so this patch doesn't use it yet.

I think the first thing is to figure out what is the ideal API, ignoring
backward compatibility.  In this ideal case, I think we'd just want
a single arg which takes a "region descriptor" (along the lines of what
you described earlier, tho its format would be opaque) with methods like
`region-contiguous-p', `region-beginning', `region-end',
`region-chunks', `region-extract', ...

Then we can try and figure how to adapt it to the real world and how to
get from here to there.  But I think it mostly means we'll want to go
from two args (START/END) to just a single arg.  So adding an argument
doesn't seem to be the obvious best choice.


        Stefan





  reply	other threads:[~2015-07-07 12:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10 14:58 bug#19829: 25.0.50; query-replace in rectangle regions do not honor boundaries Bastien
2015-02-10 23:40 ` Juri Linkov
2015-02-12  0:57   ` Juri Linkov
2015-02-12 14:33     ` Stefan Monnier
2015-02-13  0:54       ` Juri Linkov
2015-02-14  3:59         ` Stefan Monnier
2015-02-18 18:30           ` Juri Linkov
2015-02-18 22:56             ` Stefan Monnier
2015-02-19 19:12               ` Juri Linkov
2015-02-19 21:29                 ` Stefan Monnier
2015-02-23 19:19                   ` Juri Linkov
2015-03-11 20:31                     ` Stefan Monnier
2015-03-12 19:19                       ` Juri Linkov
2015-03-13  1:04                         ` Stefan Monnier
2015-06-30 20:42                       ` bug#19829: 25.0.50; Design of commands operating on rectangular regions Juri Linkov
2015-07-01  2:29                         ` Stefan Monnier
2015-07-01 22:17                           ` Juri Linkov
2015-07-02  3:02                             ` Stefan Monnier
2015-07-02 22:40                               ` Juri Linkov
2015-07-07 12:20                                 ` Stefan Monnier [this message]
2015-07-07 22:12                                   ` Juri Linkov
2015-07-07 21:27                         ` Richard Stallman
2015-07-07 22:15                           ` Juri Linkov
2015-02-19 14:27             ` bug#19829: 25.0.50; query-replace in rectangle regions do not honor boundaries Bastien
2015-11-13 23:32 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva8v9xwar.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=19829@debbugs.gnu.org \
    --cc=bzg@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.