* Re: [elpa] externals/pabbrev 6e3c38e 1/2: Safe access of subsequence.
[not found] ` <E1ZNJdK-0005vN-Ef@vcs.savannah.gnu.org>
@ 2015-08-06 19:52 ` Stefan Monnier
2015-08-06 21:19 ` Phillip Lord
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2015-08-06 19:52 UTC (permalink / raw)
To: emacs-devel; +Cc: Phillip Lord
> Emacs 25 crashes when the indexes for cl-subseq are out-of-bounds,
^^^^^^^
Just checking: you mean "signals an error" or "burps", right? If it
really crashes, we have a problem.
> while previous Emacs silently ignored. Better to handle this here.
This change in cl-subseq was controversial, so if you feel that it
should be reverted, you might like to file a bug report.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [elpa] externals/pabbrev 6e3c38e 1/2: Safe access of subsequence.
2015-08-06 19:52 ` [elpa] externals/pabbrev 6e3c38e 1/2: Safe access of subsequence Stefan Monnier
@ 2015-08-06 21:19 ` Phillip Lord
0 siblings, 0 replies; 2+ messages in thread
From: Phillip Lord @ 2015-08-06 21:19 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Emacs 25 crashes when the indexes for cl-subseq are out-of-bounds,
> ^^^^^^^
> Just checking: you mean "signals an error" or "burps", right? If it
> really crashes, we have a problem.
Sorry, very poor wording indeed. Signals an error, yes.
>> while previous Emacs silently ignored. Better to handle this here.
>
> This change in cl-subseq was controversial, so if you feel that it
> should be reverted, you might like to file a bug report.
I just asked about this (see "behaviour change in cl-subseq"), and I am
sorry that I missed the controversy previously.
I am inclined to think that the new behaviour is better than the
existing behaviour, although suspect that it may cause a fair few
breakages when Emacs 25 is released (fortunately, Eric Fraga is a
pabbrev user running on Emacs 25 and complained).
As I said to Leo in the other thread, I think the docstrings need
patching. Exceptional behaviour was undocumented before and is
undocumented now. Happy to do this, but will do via a merge-request if
that is okay by you. Then I can get feedback on my patch before it goes
onto trunk.
Phil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-06 21:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150806114649.22707.84507@vcs.savannah.gnu.org>
[not found] ` <E1ZNJdK-0005vN-Ef@vcs.savannah.gnu.org>
2015-08-06 19:52 ` [elpa] externals/pabbrev 6e3c38e 1/2: Safe access of subsequence Stefan Monnier
2015-08-06 21:19 ` Phillip Lord
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.