From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20001: bug#6267: 23.1; invalid XML in nested comments produced by comment-region Date: Sat, 19 Sep 2015 00:07:33 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1442635704 1066 80.91.229.3 (19 Sep 2015 04:08:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Sep 2015 04:08:24 +0000 (UTC) Cc: patrik.h.hagglund@ericsson.com, 6267@debbugs.gnu.org, 20001@debbugs.gnu.org To: Ivan Andrus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 19 06:08:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zd9Rd-0003AM-FT for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Sep 2015 06:08:13 +0200 Original-Received: from localhost ([::1]:43457 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zd9Rc-0005ET-KP for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Sep 2015 00:08:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zd9RX-0005AN-4N for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2015 00:08:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zd9RS-0005Ke-5M for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2015 00:08:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zd9RS-0005Ka-2r for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2015 00:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zd9RR-0002Mk-O8 for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2015 00:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Sep 2015 04:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20001 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20001-submit@debbugs.gnu.org id=B20001.14426356639064 (code B ref 20001); Sat, 19 Sep 2015 04:08:01 +0000 Original-Received: (at 20001) by debbugs.gnu.org; 19 Sep 2015 04:07:43 +0000 Original-Received: from localhost ([127.0.0.1]:37395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zd9R9-0002M7-30 for submit@debbugs.gnu.org; Sat, 19 Sep 2015 00:07:43 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:39944) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zd9R6-0002Lw-Ff; Sat, 19 Sep 2015 00:07:41 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AxFgA731xV/2yixEVcgxCEAoVVu0CHSwQCAoE8OxIBAQEBAQEBgQpBBYNdAQEEViMQCw4mEhQYDSSIP88jAQEBAQYBAQEBHos6hQUHhC0FnxeDa5A9gUUjYYMzIoJ4AQEB X-IPAS-Result: A0AxFgA731xV/2yixEVcgxCEAoVVu0CHSwQCAoE8OxIBAQEBAQEBgQpBBYNdAQEEViMQCw4mEhQYDSSIP88jAQEBAQYBAQEBHos6hQUHhC0FnxeDa5A9gUUjYYMzIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="165285987" Original-Received: from 69-196-162-108.dsl.teksavvy.com (HELO ceviche.home) ([69.196.162.108]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 19 Sep 2015 00:07:39 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 32FA06619A; Sat, 19 Sep 2015 00:07:33 -0400 (EDT) In-Reply-To: (Ivan Andrus's message of "Fri, 18 Sep 2015 15:14:03 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106703 Archived-At: The approach looks fine, thank you. > +(defvar comment-quote-nested-function #'comment-quote-nested-default [...] > + (when (and comment-quote-nested > + comment-quote-nested-function comment-quote-nested-function will always be a function so it should never be nil, so there's no need to test it here. > +The arguments CS and CE are regular expressions matching comment > +starting and ending delimiters respectively. AFAICT this is not true. They're just strings, not regexps. > + (make-local-variable 'comment-quote-nested-function) > + (setq comment-quote-nested-function 'nxml-comment-quote-nested) I know the rest of the file doesn't use it, but please in new code use: (setq-local comment-quote-nested-function #'nxml-comment-quote-nested) -- Stefan