From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23135: [PATCH] Support completion of bang-rules in CSS mode Date: Mon, 28 Mar 2016 11:16:01 -0400 Message-ID: References: <1459169573.32373.0@smtp.gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1459178245 28132 80.91.229.3 (28 Mar 2016 15:17:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Mar 2016 15:17:25 +0000 (UTC) Cc: 23135@debbugs.gnu.org To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 28 17:17:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1akYun-0006GO-6P for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Mar 2016 17:17:13 +0200 Original-Received: from localhost ([::1]:41275 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akYum-000898-4F for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Mar 2016 11:17:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akYuf-00084e-OT for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 11:17:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akYuc-0004cK-IS for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 11:17:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akYuc-0004c3-Ec for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 11:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1akYuc-0002xT-AJ for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 11:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Mar 2016 15:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23135 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.145917818511305 (code B ref -1); Mon, 28 Mar 2016 15:17:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Mar 2016 15:16:25 +0000 Original-Received: from localhost ([127.0.0.1]:42173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akYu1-0002wH-0g for submit@debbugs.gnu.org; Mon, 28 Mar 2016 11:16:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akYtz-0002vx-UO for submit@debbugs.gnu.org; Mon, 28 Mar 2016 11:16:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akYtp-0004NU-3D for submit@debbugs.gnu.org; Mon, 28 Mar 2016 11:16:18 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:40770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akYtp-0004NQ-0P for submit@debbugs.gnu.org; Mon, 28 Mar 2016 11:16:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akYtj-0007NY-QU for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 11:16:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akYtg-0004Kx-Kr for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 11:16:07 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:43221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akYtg-0004KQ-GH for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 11:16:04 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id u2SFGaZX020964; Mon, 28 Mar 2016 11:16:36 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 84349AE071; Mon, 28 Mar 2016 11:16:01 -0400 (EDT) In-Reply-To: <1459169573.32373.0@smtp.gmail.com> ("Simen =?UTF-8?Q?Heggest=C3=B8yl?="'s message of "Mon, 28 Mar 2016 14:52:53 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5625=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5625> : inlines <4594> : streams <1610251> : uri <2174962> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115645 Archived-At: > The attached patch adds support for completing bang-rules (rules that > start with "!") in CSS and SCSS mode. Looks fine, thanks. > + (list (point) pos (append (if sassy scss-bang-ids) > + css-bang-ids)))))) This duplicates code that's already elsewhere. Maybe we should have a new buffer-local var to keep the (s)css-bang-ids value appropriate for the current mode. Stefan