From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: "Simen Heggestøyl" <simenheg@gmail.com>
Cc: 23135@debbugs.gnu.org
Subject: bug#23135: [PATCH] Support completion of bang-rules in CSS mode
Date: Mon, 28 Mar 2016 11:16:01 -0400 [thread overview]
Message-ID: <jwva8liskjf.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <1459169573.32373.0@smtp.gmail.com> ("Simen Heggestøyl"'s message of "Mon, 28 Mar 2016 14:52:53 +0200")
> The attached patch adds support for completing bang-rules (rules that
> start with "!") in CSS and SCSS mode.
Looks fine, thanks.
> + (list (point) pos (append (if sassy scss-bang-ids)
> + css-bang-ids))))))
This duplicates code that's already elsewhere. Maybe we should have
a new buffer-local var to keep the (s)css-bang-ids value appropriate for
the current mode.
Stefan
next prev parent reply other threads:[~2016-03-28 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 12:52 bug#23135: [PATCH] Support completion of bang-rules in CSS mode Simen Heggestøyl
2016-03-28 15:16 ` Stefan Monnier [this message]
2016-03-30 16:33 ` Simen Heggestøyl
2016-03-30 21:06 ` Stefan Monnier
2016-03-31 19:23 ` Simen Heggestøyl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva8liskjf.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=23135@debbugs.gnu.org \
--cc=simenheg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.